Commit 87e6000e authored by rch's avatar rch Committed by Commit bot

Add a new histogram for tracking how much time is spent resolving hosts

for QUIC sessions.

Review URL: https://codereview.chromium.org/546133002

Cr-Commit-Position: refs/heads/master@{#293747}
parent 855129e7
...@@ -211,6 +211,7 @@ class QuicStreamFactory::Job { ...@@ -211,6 +211,7 @@ class QuicStreamFactory::Job {
CompletionCallback callback_; CompletionCallback callback_;
AddressList address_list_; AddressList address_list_;
base::TimeTicks disk_cache_load_start_time_; base::TimeTicks disk_cache_load_start_time_;
base::TimeTicks dns_resolution_start_time_;
base::WeakPtrFactory<Job> weak_factory_; base::WeakPtrFactory<Job> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(Job); DISALLOW_COPY_AND_ASSIGN(Job);
}; };
...@@ -315,6 +316,7 @@ int QuicStreamFactory::Job::DoResolveHost() { ...@@ -315,6 +316,7 @@ int QuicStreamFactory::Job::DoResolveHost() {
} }
io_state_ = STATE_RESOLVE_HOST_COMPLETE; io_state_ = STATE_RESOLVE_HOST_COMPLETE;
dns_resolution_start_time_ = base::TimeTicks::Now();
return host_resolver_.Resolve( return host_resolver_.Resolve(
HostResolver::RequestInfo(server_id_.host_port_pair()), HostResolver::RequestInfo(server_id_.host_port_pair()),
DEFAULT_PRIORITY, DEFAULT_PRIORITY,
...@@ -325,6 +327,8 @@ int QuicStreamFactory::Job::DoResolveHost() { ...@@ -325,6 +327,8 @@ int QuicStreamFactory::Job::DoResolveHost() {
} }
int QuicStreamFactory::Job::DoResolveHostComplete(int rv) { int QuicStreamFactory::Job::DoResolveHostComplete(int rv) {
UMA_HISTOGRAM_TIMES("Net.QuicSession.HostResolutionTime",
base::TimeTicks::Now() - dns_resolution_start_time_);
if (rv != OK) if (rv != OK)
return rv; return rv;
......
...@@ -16562,6 +16562,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -16562,6 +16562,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary> </summary>
</histogram> </histogram>
<histogram name="Net.QuicSession.HostResolutionTime" units="milliseconds">
<owner>rch@chromium.org</owner>
<summary>
Time spent resolving the DNS name of the server for a QUIC connection.
</summary>
</histogram>
<histogram name="Net.QuicSession.IncorrectConnectionIDsReceived"> <histogram name="Net.QuicSession.IncorrectConnectionIDsReceived">
<owner>rch@chromium.org</owner> <owner>rch@chromium.org</owner>
<summary> <summary>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment