Commit 882891f7 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Partial Reland [base] Update TaskTraits documentation to hint that destination is mandatory

This is a partial reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1635827
for the documentation update (while not yet mandatory, it's already the
desired syntax while we fix the remaining straddlers).

TBR=fdoray@chromium.org

Bug: 968047
Change-Id: I7e897f4ecb2ba6075ba754695bbbd30ff0439de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759055
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688714}
parent 3233d8f2
...@@ -212,13 +212,15 @@ class BASE_EXPORT TaskTraits { ...@@ -212,13 +212,15 @@ class BASE_EXPORT TaskTraits {
// WithBaseSyncPrimitives in any order to the constructor. // WithBaseSyncPrimitives in any order to the constructor.
// //
// E.g. // E.g.
// constexpr base::TaskTraits default_traits = {}; // constexpr base::TaskTraits default_traits = {base::ThreadPool()};
// constexpr base::TaskTraits user_visible_traits = // constexpr base::TaskTraits user_visible_traits = {
// {base::TaskPriority::USER_VISIBLE}; // base::ThreadPool(), base::TaskPriority::USER_VISIBLE};
// constexpr base::TaskTraits user_visible_may_block_traits = { // constexpr base::TaskTraits user_visible_may_block_traits = {
// base::TaskPriority::USER_VISIBLE, base::MayBlock()}; // base::ThreadPool(), base::TaskPriority::USER_VISIBLE, base::MayBlock()
// };
// constexpr base::TaskTraits other_user_visible_may_block_traits = { // constexpr base::TaskTraits other_user_visible_may_block_traits = {
// base::MayBlock(), base::TaskPriority::USER_VISIBLE}; // base::ThreadPool(), base::MayBlock(), base::TaskPriority::USER_VISIBLE
// };
template <class... ArgTypes, template <class... ArgTypes,
class CheckArgumentsAreValid = std::enable_if_t< class CheckArgumentsAreValid = std::enable_if_t<
trait_helpers::AreValidTraits<ValidTrait, ArgTypes...>::value || trait_helpers::AreValidTraits<ValidTrait, ArgTypes...>::value ||
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment