Add corresponding nickname autofill_private api test

addNewCreditCard creates a credit card without nickname.
updateExistingCreditCard will add a nickname to this card.

Bug: 1082013
Change-Id: I0e333f55552481070437777d40e1376a6f10404e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226088Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#774681}

chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

@@ -348,7 +348,6 @@ ExtensionFunction::ResponseAction AutofillPrivateSaveCreditCardFunction::Run() {
   }
 
   // TODO(crbug.com/1063426): Log nickname management via settings page.
-  // TODO(crbug.com/1063426): add corresponding nickname autofill_private test.
   if (card->nickname) {
     credit_card.SetNickname(base::UTF8ToUTF16(*card->nickname));
   }

chrome/test/data/extensions/api_test/autofill_private/test.js

@@ -185,8 +185,8 @@ var availableTests = [
     function filterCardProperties(cards) {
       return cards.map(cards => {
         var filteredCards = {};
-        ['name', 'cardNumber', 'expirationMonth', 'expirationYear'].forEach(
-            property => {
+        ['name', 'cardNumber', 'expirationMonth', 'expirationYear', 'nickname']
+            .forEach(property => {
               filteredCards[property] = cards[property];
             });
         return filteredCards;
@@ -206,7 +206,8 @@ var availableTests = [
                       name: CARD_NAME,
                       cardNumber: NUMBER,
                       expirationMonth: EXP_MONTH,
-                      expirationYear: EXP_YEAR
+                      expirationYear: EXP_YEAR,
+                      nickname: undefined
                     }],
                     filterCardProperties(cardList));
               }));
@@ -223,11 +224,13 @@ var availableTests = [
   function updateExistingCreditCard() {
     var UPDATED_CARD_NAME = 'UpdatedCardName';
     var UPDATED_EXP_YEAR = '2888';
+    var UPDATED_NICKNAME = 'New nickname';
 
     function filterCardProperties(cards) {
       return cards.map(cards => {
         var filteredCards = {};
-        ['guid', 'name', 'cardNumber', 'expirationMonth', 'expirationYear']
+        ['guid', 'name', 'cardNumber', 'expirationMonth', 'expirationYear',
+         'nickname']
             .forEach(property => {
               filteredCards[property] = cards[property];
             });
@@ -252,7 +255,8 @@ var availableTests = [
                       name: UPDATED_CARD_NAME,
                       cardNumber: NUMBER,
                       expirationMonth: EXP_MONTH,
-                      expirationYear: UPDATED_EXP_YEAR
+                      expirationYear: UPDATED_EXP_YEAR,
+                      nickname: UPDATED_NICKNAME
                     }],
                     filterCardProperties(cardList));
               }));
@@ -262,7 +266,8 @@ var availableTests = [
           chrome.autofillPrivate.saveCreditCard({
             guid: cardGuid,
             name: UPDATED_CARD_NAME,
-            expirationYear: UPDATED_EXP_YEAR
+            expirationYear: UPDATED_EXP_YEAR,
+            nickname: UPDATED_NICKNAME
           });
         }));
   },