Revert "ExternalVkImageBacking: fix concurrent read problem"

This reverts commit 0c9696bf.

Reason for revert: potential suspect for failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28NVIDIA%29/25848

Original change's description:
> ExternalVkImageBacking: fix concurrent read problem
> 
> Concurrent read access from both GL and Vulkan is not allowed.
> Get rid of the concurrent read problem by releasing the texture
> from GL temporarily, when a Vulkan read is requested. And resume
> GL read access, when the Vulkan read access is over.
> Current chrome GL and Vulkan concurrent read pattern is - Blink holds
> and caches read access for a backing shared image for a WebGL or
> 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just
> before playing back DDL and releases the read access after playing back
> DDL and before SwapBuffers. The GPU will not schedule other tasks
> between playing back DDL and SwapBuffers. So it should be safe to
> temporarily pause GL read access.
> 
> Bug: 1104231
> Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#791022}

TBR=penghuang@chromium.org,vasilyt@chromium.org

Change-Id: Ibcadd314ed775910395b2d29d6133a1fcbb2aeb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315918Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791271}

gpu/command_buffer/service/external_vk_image_backing.cc

@@ -388,32 +388,6 @@ bool ExternalVkImageBacking::BeginAccess(
       UpdateContent(kInGLTexture);
   }
 
-  if (gl_reads_in_progress_ && need_synchronization()) {
-    // To avoid concurrent read access from both GL and vulkan, if there is
-    // unfinished GL read access, we will release the GL texture temporarily.
-    // And when this vulkan access is over, we will acquire the GL texture to
-    // resume the GL access.
-    DCHECK(!is_gl);
-    DCHECK(readonly);
-    DCHECK(texture_passthrough_ || texture_);
-
-    GLuint texture_id = texture_passthrough_
-                            ? texture_passthrough_->service_id()
-                            : texture_->service_id();
-    context_state()->MakeCurrent(/*gl_surface=*/nullptr, /*needs_gl=*/true);
-
-    GrVkImageInfo info;
-    auto result = backend_texture_.getVkImageInfo(&info);
-    DCHECK(result);
-    DCHECK_EQ(info.fCurrentQueueFamily, VK_QUEUE_FAMILY_EXTERNAL);
-    DCHECK_NE(info.fImageLayout, VK_IMAGE_LAYOUT_UNDEFINED);
-    DCHECK_NE(info.fImageLayout, VK_IMAGE_LAYOUT_PREINITIALIZED);
-    auto release_semaphore =
-        ExternalVkImageGLRepresentationShared::ReleaseTexture(
-            external_semaphore_pool(), texture_id, info.fImageLayout);
-    EndAccessInternal(readonly, std::move(release_semaphore));
-  }
-
   if (!BeginAccessInternal(readonly, external_semaphores))
     return false;
 
@@ -478,32 +452,6 @@ void ExternalVkImageBacking::EndAccess(bool readonly,
       latest_content_ = kInVkImage | kInGLTexture;
     }
   }
-
-  if (gl_reads_in_progress_ && need_synchronization()) {
-    // When vulkan read access is finished, if there is unfinished GL read
-    // access, we need to resume GL read access.
-    DCHECK(!is_gl);
-    DCHECK(readonly);
-    DCHECK(texture_passthrough_ || texture_);
-    GLuint texture_id = texture_passthrough_
-                            ? texture_passthrough_->service_id()
-                            : texture_->service_id();
-    context_state()->MakeCurrent(/*gl_surface=*/nullptr, /*needs_gl=*/true);
-    std::vector<ExternalSemaphore> external_semaphores;
-    BeginAccessInternal(true, &external_semaphores);
-    DCHECK_LE(external_semaphores.size(), 1u);
-
-    for (auto& semaphore : external_semaphores) {
-      GrVkImageInfo info;
-      auto result = backend_texture_.getVkImageInfo(&info);
-      DCHECK(result);
-      DCHECK_EQ(info.fCurrentQueueFamily, VK_QUEUE_FAMILY_EXTERNAL);
-      DCHECK_NE(info.fImageLayout, VK_IMAGE_LAYOUT_UNDEFINED);
-      DCHECK_NE(info.fImageLayout, VK_IMAGE_LAYOUT_PREINITIALIZED);
-      ExternalVkImageGLRepresentationShared::AcquireTexture(
-          &semaphore, texture_id, info.fImageLayout);
-    }
-  }
 }
 
 void ExternalVkImageBacking::Update(std::unique_ptr<gfx::GpuFence> in_fence) {