Commit 8ab24433 authored by Huanzhong Huang's avatar Huanzhong Huang Committed by Commit Bot

[iOS] CBD cleanup: feature flag

Part of the new clear browsing data dialog cleanup effort. This change
removes the feature flag definition.

Bug: 947456
Change-Id: I2231e58c58583ba6b825a32c6390937b0894f9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985012
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729704}
parent 7ebe6372
...@@ -4,12 +4,5 @@ ...@@ -4,12 +4,5 @@
#include "ios/chrome/browser/browsing_data/browsing_data_features.h" #include "ios/chrome/browser/browsing_data/browsing_data_features.h"
const base::Feature kNewClearBrowsingDataUI{"NewClearBrowsingDataUI",
base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kWebClearBrowsingData{"WebClearBrowsingData", const base::Feature kWebClearBrowsingData{"WebClearBrowsingData",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
bool IsNewClearBrowsingDataUIEnabled() {
return base::FeatureList::IsEnabled(kNewClearBrowsingDataUI);
}
...@@ -7,14 +7,8 @@ ...@@ -7,14 +7,8 @@
#include "base/feature_list.h" #include "base/feature_list.h"
// Feature flag to enable new Clear Browsing Data UI.
extern const base::Feature kNewClearBrowsingDataUI;
// Feature to use the clear browsing data from web instead of the one from // Feature to use the clear browsing data from web instead of the one from
// chrome. // chrome.
extern const base::Feature kWebClearBrowsingData; extern const base::Feature kWebClearBrowsingData;
// Whether the new Clear Browsing Data UI is enabled.
bool IsNewClearBrowsingDataUIEnabled();
#endif // IOS_CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_FEATURES_H_ #endif // IOS_CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_FEATURES_H_
...@@ -314,10 +314,6 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -314,10 +314,6 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAutofillIOSDelayBetweenFieldsName, flag_descriptions::kAutofillIOSDelayBetweenFieldsName,
flag_descriptions::kAutofillIOSDelayBetweenFieldsDescription, flag_descriptions::kAutofillIOSDelayBetweenFieldsDescription,
flags_ui::kOsIos, MULTI_VALUE_TYPE(kAutofillIOSDelayBetweenFieldsChoices)}, flags_ui::kOsIos, MULTI_VALUE_TYPE(kAutofillIOSDelayBetweenFieldsChoices)},
{"new-clear-browsing-data-ui",
flag_descriptions::kNewClearBrowsingDataUIName,
flag_descriptions::kNewClearBrowsingDataUIDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kNewClearBrowsingDataUI)},
{"autofill-show-all-profiles-on-prefilled-forms", {"autofill-show-all-profiles-on-prefilled-forms",
flag_descriptions::kAutofillShowAllSuggestionsOnPrefilledFormsName, flag_descriptions::kAutofillShowAllSuggestionsOnPrefilledFormsName,
flag_descriptions::kAutofillShowAllSuggestionsOnPrefilledFormsDescription, flag_descriptions::kAutofillShowAllSuggestionsOnPrefilledFormsDescription,
......
...@@ -266,10 +266,6 @@ const char kMobileGoogleSRPDescription[] = ...@@ -266,10 +266,6 @@ const char kMobileGoogleSRPDescription[] =
"Request the Mobile version of Google SRP by default when the desktop mode " "Request the Mobile version of Google SRP by default when the desktop mode "
"is requested by default."; "is requested by default.";
const char kNewClearBrowsingDataUIName[] = "Clear Browsing Data UI";
const char kNewClearBrowsingDataUIDescription[] =
"Enable new Clear Browsing Data UI.";
const char kNewOmniboxPopupLayoutName[] = "New omnibox popup"; const char kNewOmniboxPopupLayoutName[] = "New omnibox popup";
const char kNewOmniboxPopupLayoutDescription[] = const char kNewOmniboxPopupLayoutDescription[] =
"Switches the omnibox suggestions and omnibox itself to display the new " "Switches the omnibox suggestions and omnibox itself to display the new "
......
...@@ -232,10 +232,6 @@ extern const char kMarkHttpAsDescription[]; ...@@ -232,10 +232,6 @@ extern const char kMarkHttpAsDescription[];
extern const char kMobileGoogleSRPName[]; extern const char kMobileGoogleSRPName[];
extern const char kMobileGoogleSRPDescription[]; extern const char kMobileGoogleSRPDescription[];
// Title and description for the flag to enable new Clear Browsing Data UI.
extern const char kNewClearBrowsingDataUIName[];
extern const char kNewClearBrowsingDataUIDescription[];
// Title and description for the flag to display new omnibox popup. // Title and description for the flag to display new omnibox popup.
extern const char kNewOmniboxPopupLayoutName[]; extern const char kNewOmniboxPopupLayoutName[];
extern const char kNewOmniboxPopupLayoutDescription[]; extern const char kNewOmniboxPopupLayoutDescription[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment