Commit 8ab6735a authored by bttk's avatar bttk Committed by Commit Bot

metrics: Refactor CachedMetrics in components/gcm_driver/

Bug: 1046181
Change-Id: I58390007cfdc98199a21e2e07df31d7c575b8185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019477
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Reviewed-by: default avatarEnder <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742387}
parent a8819ec3
...@@ -16,7 +16,7 @@ import org.json.JSONObject; ...@@ -16,7 +16,7 @@ import org.json.JSONObject;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.Log; import org.chromium.base.Log;
import org.chromium.base.StrictModeContext; import org.chromium.base.StrictModeContext;
import org.chromium.base.metrics.CachedMetrics; import org.chromium.base.metrics.RecordHistogram;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
...@@ -216,10 +216,8 @@ public class LazySubscriptionsManager { ...@@ -216,10 +216,8 @@ public class LazySubscriptionsManager {
queueJSON = filterMessageBasedOnCollapseKey(queueJSON, message.getCollapseKey()); queueJSON = filterMessageBasedOnCollapseKey(queueJSON, message.getCollapseKey());
} }
// Use {@link CachedMetrics} so this gets reported when native is RecordHistogram.recordCount100Histogram(
// loaded instead of calling native right away. "PushMessaging.QueuedMessagesCount", queueJSON.length());
new CachedMetrics.Count100HistogramSample("PushMessaging.QueuedMessagesCount")
.record(queueJSON.length());
// If the queue is full remove the oldest message. // If the queue is full remove the oldest message.
if (queueJSON.length() == MESSAGES_QUEUE_SIZE) { if (queueJSON.length() == MESSAGES_QUEUE_SIZE) {
......
...@@ -18,7 +18,6 @@ import org.junit.runner.RunWith; ...@@ -18,7 +18,6 @@ import org.junit.runner.RunWith;
import org.robolectric.annotation.Config; import org.robolectric.annotation.Config;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.metrics.CachedMetrics;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.test.ShadowRecordHistogram; import org.chromium.base.metrics.test.ShadowRecordHistogram;
import org.chromium.base.test.BaseRobolectricTestRunner; import org.chromium.base.test.BaseRobolectricTestRunner;
...@@ -33,8 +32,6 @@ import java.util.Set; ...@@ -33,8 +32,6 @@ import java.util.Set;
public class LazySubscriptionsManagerTest { public class LazySubscriptionsManagerTest {
@Before @Before
public void setUp() { public void setUp() {
// This commits and clears any cached metrics.
CachedMetrics.commitCachedMetrics();
ShadowRecordHistogram.reset(); ShadowRecordHistogram.reset();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment