GitLab

Revert "viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest"

This reverts commit aa28a986.

Reason for revert: Has caused stack-use-after-scope errors on ASAn bot.

First build failure: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23580

Sample output:
[ RUN      ] GLRendererTest.OverlaySyncTokensAreProcessed
=================================================================
==9679==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f2ca060c548 at pc 0x000000736f66 bp 0x7ffffdbd9de0 sp 0x7ffffdbd9dd8
READ of size 8 at 0x7f2ca060c548 thread T0
    #0 0x736f65 in end buildtools/third_party/libc++/trunk/include/vector:1481:30
    #1 0x736f65 in viz::(anonymous namespace)::CollectResources(std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> >*, std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> > const&, cc::BlockingTaskRunner*) components/viz/service/display/gl_renderer_unittest.cc:1925
    #2 0x3680f76 in Run base/callback.h:92:12
    #3 0x3680f76 in cc::DisplayResourceProvider::DeleteAndReturnUnusedResourcesToChild(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle, std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > const&) cc/resources/display_resource_provider.cc:255
    #4 0x367dfbf in cc::DisplayResourceProvider::DestroyChildInternal(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle) cc/resources/display_resource_provider.cc:145:3
    #5 0x367d6d0 in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:35:5
    #6 0x367e10d in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:33:53
    #7 0x74ad4e in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5
    #8 0x74ad4e in reset buildtools/third_party/libc++/trunk/include/memory:2585
    #9 0x74ad4e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539
    #10 0x74ad4e in viz::(anonymous namespace)::GLRendererTest_OverlaySyncTokensAreProcessed_Test::TestBody() components/viz/service/display/gl_renderer_unittest.cc:2211
....

Original change's description:
> viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest
> 
> As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox
> into LayerTreeREsourceProvider, move the call of
> DisplayResourceProvider::CreateResourceFromTextureMailbox
> into LayerTreeResourceProvider::CreateResourceFromTextureMailbox.
> 
> The usage of CreateResourceFromTextureMailbox is listed here:
> https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit
> 
> BUG=757291
> 
> Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529
> Reviewed-on: https://chromium-review.googlesource.com/654444
> Commit-Queue: Xing Xu <xing.xu@intel.com>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500974}

TBR=danakj@chromium.org,sunnyps@chromium.org,xing.xu@intel.com

Change-Id: I4429d959bea725598662c5bee5c7f1c70acba22f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757291
Reviewed-on: https://chromium-review.googlesource.com/662470Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501133}