Commit 8bc8d513 authored by Matt Falkenhagen's avatar Matt Falkenhagen Committed by Commit Bot

service worker: Remove unused implementation of a virtual function.

All subclasses define their own RequestStillValid() already, so we can
make it a pure virtual method.

Change-Id: Ic5bf5deb40eb52e6f93733a5770b1e3f1761b91f
Reviewed-on: https://chromium-review.googlesource.com/c/1317418Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605255}
parent 8dff7904
...@@ -46,7 +46,7 @@ class CONTENT_EXPORT ServiceWorkerURLJobWrapper { ...@@ -46,7 +46,7 @@ class CONTENT_EXPORT ServiceWorkerURLJobWrapper {
// the request should still continue, or if processing should be aborted. // the request should still continue, or if processing should be aborted.
// When false is returned, this sets |*result| to an appropriate error. // When false is returned, this sets |*result| to an appropriate error.
virtual bool RequestStillValid( virtual bool RequestStillValid(
ServiceWorkerMetrics::URLRequestJobResult* result); ServiceWorkerMetrics::URLRequestJobResult* result) = 0;
// Called to signal that loading failed, and that the resource being loaded // Called to signal that loading failed, and that the resource being loaded
// was a main resource. // was a main resource.
......
...@@ -304,11 +304,6 @@ class ServiceWorkerURLRequestJob::NavigationPreloadMetrics { ...@@ -304,11 +304,6 @@ class ServiceWorkerURLRequestJob::NavigationPreloadMetrics {
DISALLOW_COPY_AND_ASSIGN(NavigationPreloadMetrics); DISALLOW_COPY_AND_ASSIGN(NavigationPreloadMetrics);
}; };
bool ServiceWorkerURLRequestJob::Delegate::RequestStillValid(
ServiceWorkerMetrics::URLRequestJobResult* result) {
return true;
}
ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob( ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob(
net::URLRequest* request, net::URLRequest* request,
net::NetworkDelegate* network_delegate, net::NetworkDelegate* network_delegate,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment