Commit 8be7c692 authored by Keishi Hattori's avatar Keishi Hattori Committed by Commit Bot

Revert "[Reland] Oilpan: Enable HeapCompaction for incremental marking"

This reverts commit 2cc1550c.

Reason for revert: Caused crashes
crbug.com/902832
crbug.com/902848

Original change's description:
> [Reland] Oilpan: Enable HeapCompaction for incremental marking
> 
> Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC.
> 
> Bug: 864425
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#603477}
> Change-Id: I506868b5ea224714491fb4dfd9403e5311550255
> Reviewed-on: https://chromium-review.googlesource.com/c/1316954
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605608}

TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864425
Change-Id: I864a985719c1c12bf4b56f05d228c6ff8450ef5f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1326341Reviewed-by: default avatarKeishi Hattori <keishi@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606449}
parent aaeff5e6
......@@ -368,10 +368,14 @@ bool HeapCompact::ShouldCompact(ThreadHeap* heap,
return force_compaction_gc_;
}
// TODO(keishi): Should be enable after fixing the crashes.
if (marking_type == BlinkGC::kIncrementalMarking)
return false;
// TODO(harukamt): Add kIncrementalIdleGC and kIncrementalV8FollowupGC when we
// enable heap compaction for incremental marking.
if (reason != BlinkGC::GCReason::kIdleGC &&
reason != BlinkGC::GCReason::kPreciseGC &&
reason != BlinkGC::GCReason::kIncrementalIdleGC &&
reason != BlinkGC::GCReason::kIncrementalV8FollowupGC &&
reason != BlinkGC::GCReason::kForcedGC)
return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment