Commit 8c3cf479 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Fix -Wimplicit-fallthrough warnings for Chrome OS.

Adds a missing break; without this change as shelf context menu buttons
would be treated as submenus in release builds. Since the button
item type is not yet used, this is not observable in practice.

This CL was uploaded by git cl split.

R=msw@chromium.org

Bug: 177475
Change-Id: I913b81eef071c6a0dcc4f67c206d551cdf5be639
Reviewed-on: https://chromium-review.googlesource.com/899787
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarStefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534435}
parent 9d78a383
......@@ -188,6 +188,7 @@ void ShelfContextMenuModel::AddItems(ui::SimpleMenuModel* model,
break;
case ui::MenuModel::TYPE_BUTTON_ITEM:
NOTREACHED() << "TYPE_BUTTON_ITEM is not yet supported.";
break;
case ui::MenuModel::TYPE_SUBMENU:
if (item->submenu.has_value()) {
std::unique_ptr<ui::MenuModel> submenu =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment