Commit 8c874906 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Correctly disable flaky tests on device.

These tests are not failed on simulator and should only be disabled on
devices. Also Added TODOs that reference the bugs.

Bug: 954231, 954232
Change-Id: If1aa247e5686211187fddbc1b82c8051f71ab4d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574287
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652552}
parent 70e82bb3
...@@ -134,7 +134,13 @@ class ErrorPageTest ...@@ -134,7 +134,13 @@ class ErrorPageTest
// Tests that the error page is correctly displayed after navigating back to it // Tests that the error page is correctly displayed after navigating back to it
// multiple times. See http://crbug.com/944037 . // multiple times. See http://crbug.com/944037 .
TEST_P(ErrorPageTest, FLAKY_BackForwardErrorPage) { // TODO(crbug.com/954231): this test is flaky on device.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_BackForwardErrorPage BackForwardErrorPage
#else
#define MAYBE_BackForwardErrorPage FLAKY_BackForwardErrorPage
#endif
TEST_P(ErrorPageTest, MAYBE_BackForwardErrorPage) {
test::LoadUrl(web_state(), server_.GetURL("/close-socket")); test::LoadUrl(web_state(), server_.GetURL("/close-socket"));
ASSERT_TRUE(WaitForErrorText(web_state(), server_.GetURL("/close-socket"))); ASSERT_TRUE(WaitForErrorText(web_state(), server_.GetURL("/close-socket")));
......
...@@ -2034,7 +2034,13 @@ TEST_P(WebStateObserverTest, DownloadNavigation) { ...@@ -2034,7 +2034,13 @@ TEST_P(WebStateObserverTest, DownloadNavigation) {
} }
// Tests failed load after the navigation is sucessfully finished. // Tests failed load after the navigation is sucessfully finished.
TEST_P(WebStateObserverTest, FLAKY_FailedLoad) { // TODO(crbug.com/954232): this test is flaky on device.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_FailedLoad FailedLoad
#else
#define MAYBE_FailedLoad FLAKY_FailedLoad
#endif
TEST_P(WebStateObserverTest, MAYBE_FailedLoad) {
GURL url = test_server_->GetURL("/exabyte_response"); GURL url = test_server_->GetURL("/exabyte_response");
NavigationContext* context = nullptr; NavigationContext* context = nullptr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment