Commit 8d054025 authored by ttuttle's avatar ttuttle Committed by Commit bot

Domain Reliability: Don't create Service if metrics reporting disabled

Given that the metrics reporting pref is labelled in the UI as requiring
a restart to apply, this is a much simpler way of gating Domain
Reliability uploads on it.

We simply don't create the Service (so we don't collect data and upload
it) if the pref is false.

This will need to be revisited when we also start using the Monitor for
JavaScript hooks (e.g. the Navigation Error Logging API).

BUG=407170

Review URL: https://codereview.chromium.org/525303004

Cr-Commit-Position: refs/heads/master@{#293226}
parent 2e8e41dc
...@@ -6,7 +6,10 @@ ...@@ -6,7 +6,10 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/metrics/field_trial.h" #include "base/metrics/field_trial.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/browser_process.h"
#include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/domain_reliability/service.h" #include "components/domain_reliability/service.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h" #include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "content/public/browser/browser_context.h" #include "content/public/browser/browser_context.h"
...@@ -56,6 +59,11 @@ KeyedService* DomainReliabilityServiceFactory::BuildServiceInstanceFor( ...@@ -56,6 +59,11 @@ KeyedService* DomainReliabilityServiceFactory::BuildServiceInstanceFor(
if (!IsDomainReliabilityMonitoringEnabled()) if (!IsDomainReliabilityMonitoringEnabled())
return NULL; return NULL;
if (!g_browser_process->local_state()->GetBoolean(
prefs::kMetricsReportingEnabled)) {
return NULL;
}
return DomainReliabilityService::Create( return DomainReliabilityService::Create(
kDomainReliabilityUploadReporterString); kDomainReliabilityUploadReporterString);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment