Roll src/third_party/harfbuzz-ng/src/ e637a4b3d..7cde68f10 (47 commits)

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e637a4b3de2f..7cde68f10cdf

Roll for fixing kerning in GillSans, which is an AAT font with a morx,
GPOS and kern table. Apparently, kern needs to be applied, see HarfBuzz
issue: https://github.com/harfbuzz/harfbuzz/issues/1982

$ git log e637a4b3d..7cde68f10 --date=short --no-merges --format='%ad %ae %s'
2019-11-02 ebrahim [ci] install pip in fedora bot
2019-11-02 ebrahim [ci] fix fedora bot
2019-09-23 ebrahim [serialize] Extract iterable copy, copy_all
2019-10-31 behdad Minor
2019-10-31 behdad If applying morx, apply kern table even if GPOS is present and has kern
2019-10-29 behdad 2.6.4
2019-10-29 ebrahim Add in_range in hb_bytes_t to merge range_checker_t with it
2019-10-29 ebrahim [ci] Check the recipt introduce in 7152ac3
2019-10-29 ebrahim [glyf] Use contour_bounds_t::empty to simplify get_extents logic
2019-10-29 ebrahim [glyf] Refactor contour_bounds_t use to make its fields protected
2019-10-29 ebrahim Remove contour_point_t so we won't need to zero its unused var
2019-10-29 jfkthame Use proper y-scale factor for height value
2019-10-28 behdad Fix build
2019-10-29 khaledhosny [cmap] Check GID before adding ranges in format 4 & 12
2019-10-28 behdad Hopefully fix up previous commit and bots
2019-10-28 behdad [config] Make HB_NO_ERRNO work with systems defining errno as a macro
2019-10-28 behdad 2.6.3
2019-10-28 behdad Actually add +hb_font_get_nominal_glyphs()
2019-10-28 behdad Revert "Don't include codepoint 0 in the results of collect_unicodes."
2019-10-28 grieger Don't include codepoint 0 in the results of collect_unicodes. It is always assumed to be the notdef glyph.
2019-10-22 ebrahim [gpos] Don't move pointer when match_glyph_data is not set
2019-10-25 qxliu crash fix : Heap-buffer-overflow READ 2 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18513
2019-10-24 qxliu  fuzzer crash fix  https://oss-fuzz.com/testcase-detail/5643107869917184
2019-10-24 ebrahim [ci] Use custom subset fuzzer timeout for failing sanitizer bots
2019-10-23 ebrahim [ci] Add HB_NO_MT on non HB_TINY no-build-system builds
2019-10-22 behdad Remove hb-warning.cc
2019-10-21 grieger Add a specialization of array_t:hash for hb_bytes_t and hb_ubytes_t.
2019-10-21 grieger Optimize intersects_array to fix fuzzer timeout.
2019-10-22 grieger Store the hash value of a key in item_t in hb_map to reduce the number of hash computations.
2019-10-21 qxliu fuzzer crash fix: Null-dereference WRITE https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18363
2019-09-27 grieger Added profiling instructions to TESTING.md
2019-09-17 qxliu [subset] GPOS Lookup Type 2: PairPos
2019-10-21 ebrahim [fuzz] Add https://crbug.com/oss-fuzz/17898 testcase
2019-09-30 qxliu [subset] GSUB Lookup Type 6: ChainContextSubst
2019-10-16 grieger Add missing pop() for the failure case of script subsetting.
2019-10-02 grieger Rewrite hash and == function for hb_array_t as a plain loop.
2019-10-01 grieger Enforce HB_MAX_LANGSYS limit during layout subsetting.
2019-10-01 grieger Enforce HB_MAX_SCRIPTS during subsetting of the script table.
2019-10-09 behdad [buffer] Minor; improve HB_NO_BUFFER_MESSAGE
2019-10-16 ebrahim [doc] minor
2019-10-12 ebrahim [glyf] Use range_checker_t in composite_iter_t
2019-10-12 ebrahim [glyf] minor
2019-10-12 ebrahim [glyf] other cleanups
2019-10-12 ebrahim [glyf] Introduce glyf::Glyph, a hb_bytes_t/GlyphHeader pair
2019-10-12 ebrahim [glyf] minor
2019-10-12 ebrahim [glyf] Move get_contour_points to GlyphHeader
2019-10-10 bungeman Document hb_feature_t.

Created with:
  roll-dep src/third_party/harfbuzz-ng/src

R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Bug: 1004945
Change-Id: I1ac3540fe678bc0cbd7c1b9b14efb88c6ed5b587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895350
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713786}

DEPS

@@ -227,7 +227,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling HarfBuzz
   # and whatever else without interference from each other.
-  'harfbuzz_revision': 'e637a4b3de2fb8bdbc1b82e822f4a6cc579e794b',
+  'harfbuzz_revision': '7cde68f10cdf2c3ff77c1d9077475c0fc034c75c',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling Emoji Segmenter
   # and whatever else without interference from each other.

third_party/blink/web_tests/NeverFixTests

@@ -148,6 +148,10 @@ crbug.com/1018375 [ Win7 ] inspector-protocol/layout-fonts/fallback-dingbats.js
 [ Linux ] inspector-protocol/layout-fonts/mac-case-insensitive-matching.js [ Skip ]
 [ Win ] inspector-protocol/layout-fonts/mac-case-insensitive-matching.js [ Skip ]
 
+# Mac only test for Gill Sans kerning
+crbug.com/1004945 [ Linux ] fast/text/mac-aat-morx-kern.html [ Skip ]
+crbug.com/1004945 [ Win ] fast/text/mac-aat-morx-kern.html [ Skip ]
+
 # Segoe UI matching is only relevant on Windows
 [ Mac ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ Skip ]
 [ Linux ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ Skip ]

third_party/blink/web_tests/fast/text/mac-aat-morx-kern.html

+<!DOCTYPE html>
+<style>
+.gillsanstest {
+font-family: Gill Sans;
+font-size: 60px;
+}
+</style>
+<p>y needs to be kerned under the T on Gill Sans on Mac for weights under 700. <a href="https://crbug.com/1004945">https://crbug.com/1004945</a></p>
+<div class="gillsanstest" style="font-weight: 300;">TyTo</div>
+<div class="gillsanstest" style="font-weight: 500;">TyTo</div>
+<div class="gillsanstest" style="font-weight: 600;">TyTo</div>
+<div class="gillsanstest" style="font-weight: 700;">TyTo</div>
+<div class="gillsanstest" style="font-weight: 800;">TyTo</div>

third_party/harfbuzz-ng/BUILD.gn

@@ -223,7 +223,6 @@ if (use_system_harfbuzz) {
       "src/src/hb-unicode.cc",
       "src/src/hb-unicode.hh",
       "src/src/hb-utf.hh",
-      "src/src/hb-warning.cc",
       "src/src/hb.hh",
     ]
 

third_party/harfbuzz-ng/README.chromium

 Name: harfbuzz-ng
 Short Name: harfbuzz-ng
 URL: http://harfbuzz.org
-Version: 2.6.2-45
-Date: 20191016
-Revision: e637a4b3de2fb8bdbc1b82e822f4a6cc579e794b
+Version: 2.6.4-5
+Date: 20191104
+Revision: 7cde68f10cdf2c3ff77c1d9077475c0fc034c75c
 Security Critical: yes
 License: MIT
 License File: src/COPYING