Commit 8dbecfca authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

Disable unittests that failed ASan LSan tests

ExtensionApiTest.DisplayModeWindowIsInFullscreen and
ChromeNavigationBrowserTest.TransientEntryPreservedOnMultipleNavigationsDuringInterstitial
started to fail after patch crrev.com/c/1292513
Given that the patch was landed 4 hours ago, will disable the tests and
assign the bug to the patch owner.

TBR=sky@chromium.org
NOTRY=true

Bug: 897879
Change-Id: I559a1820293fe057eebb628b9d5aa962f1999020
Reviewed-on: https://chromium-review.googlesource.com/c/1294599
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601702}
parent d2ae3b7c
...@@ -99,12 +99,22 @@ class DidStartNavigationObserver : public content::WebContentsObserver { ...@@ -99,12 +99,22 @@ class DidStartNavigationObserver : public content::WebContentsObserver {
DISALLOW_COPY_AND_ASSIGN(DidStartNavigationObserver); DISALLOW_COPY_AND_ASSIGN(DidStartNavigationObserver);
}; };
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
// Fails on chromium.memory/Linux Chromium OS ASan LSan:
// https://crbug.com/897879
#define MAYBE_TransientEntryPreservedOnMultipleNavigationsDuringInterstitial \
DISABLED_TransientEntryPreservedOnMultipleNavigationsDuringInterstitial
#else
#define MAYBE_TransientEntryPreservedOnMultipleNavigationsDuringInterstitial \
TransientEntryPreservedOnMultipleNavigationsDuringInterstitial
#endif
// Test to verify that navigations are not deleting the transient // Test to verify that navigations are not deleting the transient
// NavigationEntry when showing an interstitial page and the old renderer // NavigationEntry when showing an interstitial page and the old renderer
// process is trying to navigate. See https://crbug.com/600046. // process is trying to navigate. See https://crbug.com/600046.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
ChromeNavigationBrowserTest, ChromeNavigationBrowserTest,
TransientEntryPreservedOnMultipleNavigationsDuringInterstitial) { MAYBE_TransientEntryPreservedOnMultipleNavigationsDuringInterstitial) {
StartServerWithExpiredCert(); StartServerWithExpiredCert();
GURL setup_url = GURL setup_url =
......
...@@ -61,12 +61,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ...@@ -61,12 +61,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
ASSERT_FALSE(browser()->window()->IsFullscreen()); ASSERT_FALSE(browser()->window()->IsFullscreen());
} }
#if defined(OS_MACOSX) #if defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_CHROMEOS)
// Fails on MAC: http://crbug.com/480370 // Fails on MAC: http://crbug.com/480370
// Fails on chromium.memory/Linux Chromium OS ASan LSan:
// https://crbug.com/897879
#define MAYBE_DisplayModeWindowIsInFullscreen DISABLED_DisplayModeWindowIsInFullscreen #define MAYBE_DisplayModeWindowIsInFullscreen DISABLED_DisplayModeWindowIsInFullscreen
#else #else
#define MAYBE_DisplayModeWindowIsInFullscreen DisplayModeWindowIsInFullscreen #define MAYBE_DisplayModeWindowIsInFullscreen DisplayModeWindowIsInFullscreen
#endif // defined(OS_MACOSX) #endif
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
MAYBE_DisplayModeWindowIsInFullscreen) { MAYBE_DisplayModeWindowIsInFullscreen) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment