Commit 8deb0673 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Enable "gn check" for //third_party/blink/renderer/platform/heap

* It has circular dependencies with platform:platform,
  platform/instrumentation:instrumentation, and
  platform/scheduler:scheduler. This CL updates
  |allow_circular_includes_from|s for them.

* Change visibility of platform:platform_export to be used by
  platform/heap:heap_unsanitized.

This CL has no behavior changes.

Bug: 800764
Change-Id: Iba08daca769d5c41f20fd678ef2d3cbc3c72e3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400782Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805619}
parent a909fcd0
...@@ -257,7 +257,6 @@ no_check_targets = [ ...@@ -257,7 +257,6 @@ no_check_targets = [
"//third_party/blink/renderer/modules/peerconnection:*", # 43 errors "//third_party/blink/renderer/modules/peerconnection:*", # 43 errors
"//third_party/blink/renderer/modules/webtransport:*", # 16 errors "//third_party/blink/renderer/modules/webtransport:*", # 16 errors
"//third_party/blink/renderer/modules:*", # 321 errors "//third_party/blink/renderer/modules:*", # 321 errors
"//third_party/blink/renderer/platform/heap:*", # 65 errors
"//third_party/blink/renderer/platform/loader:*", # 180 errors "//third_party/blink/renderer/platform/loader:*", # 180 errors
"//third_party/blink/renderer/platform/network:*", # 15 errors "//third_party/blink/renderer/platform/network:*", # 15 errors
"//third_party/blink/renderer/platform:*", # 72 errors "//third_party/blink/renderer/platform:*", # 72 errors
......
...@@ -238,8 +238,8 @@ source_set("platform_export") { ...@@ -238,8 +238,8 @@ source_set("platform_export") {
visibility = [] # Allow re-assignment of list. visibility = [] # Allow re-assignment of list.
visibility = [ visibility = [
":platform",
"//mojo/public/cpp/bindings:wtf_support", "//mojo/public/cpp/bindings:wtf_support",
"//third_party/blink/renderer/platform/*",
] ]
} }
...@@ -250,8 +250,8 @@ component("platform") { ...@@ -250,8 +250,8 @@ component("platform") {
"//services/device/public/mojom:mojom_blink", "//services/device/public/mojom:mojom_blink",
"//services/media_session/public/mojom:mojom_blink", "//services/media_session/public/mojom:mojom_blink",
"//third_party/blink/*", "//third_party/blink/*",
"//url/mojom:url_mojom_origin_blink",
"//url/mojom:url_mojom_gurl_blink", "//url/mojom:url_mojom_gurl_blink",
"//url/mojom:url_mojom_origin_blink",
] ]
output_name = "blink_platform" output_name = "blink_platform"
...@@ -1561,6 +1561,7 @@ component("platform") { ...@@ -1561,6 +1561,7 @@ component("platform") {
allow_circular_includes_from = [ allow_circular_includes_from = [
"//third_party/blink/renderer/platform/blob", "//third_party/blink/renderer/platform/blob",
"//third_party/blink/renderer/platform/heap:heap",
"//third_party/blink/renderer/platform/instrumentation", "//third_party/blink/renderer/platform/instrumentation",
"//third_party/blink/renderer/platform/scheduler", "//third_party/blink/renderer/platform/scheduler",
] ]
......
...@@ -39,6 +39,7 @@ source_set("heap_unsanitized") { ...@@ -39,6 +39,7 @@ source_set("heap_unsanitized") {
"//base", "//base",
"//third_party/blink/renderer/platform/wtf", "//third_party/blink/renderer/platform/wtf",
] ]
public_deps = [ "//third_party/blink/renderer/platform:platform_export" ]
} }
blink_platform_sources("heap") { blink_platform_sources("heap") {
...@@ -138,7 +139,9 @@ source_set("test_support") { ...@@ -138,7 +139,9 @@ source_set("test_support") {
"//testing/gtest", "//testing/gtest",
"//third_party/blink/public/mojom:mojom_platform_blink_headers", "//third_party/blink/public/mojom:mojom_platform_blink_headers",
"//third_party/blink/renderer/platform:bindings_buildflags", "//third_party/blink/renderer/platform:bindings_buildflags",
"//third_party/blink/renderer/platform:platform",
] ]
public_deps = [ "//base/test:test_support" ]
} }
test("blink_heap_unittests") { test("blink_heap_unittests") {
...@@ -190,8 +193,11 @@ source_set("blink_heap_unittests_sources") { ...@@ -190,8 +193,11 @@ source_set("blink_heap_unittests_sources") {
] ]
deps = [ deps = [
":test_support",
"//base", "//base",
"//base/test:test_support", "//base/test:test_support",
"//mojo/core/embedder:embedder",
"//skia:test_fonts",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/blink/renderer/platform:test_support", "//third_party/blink/renderer/platform:test_support",
......
...@@ -47,6 +47,7 @@ blink_platform_sources("instrumentation") { ...@@ -47,6 +47,7 @@ blink_platform_sources("instrumentation") {
"//services/service_manager/public/cpp", "//services/service_manager/public/cpp",
] ]
public_deps = [ "//third_party/blink/renderer/platform/heap:heap" ] public_deps = [ "//third_party/blink/renderer/platform/heap:heap" ]
allow_circular_includes_from = public_deps
} }
source_set("unit_tests") { source_set("unit_tests") {
......
...@@ -183,8 +183,10 @@ blink_platform_sources("scheduler") { ...@@ -183,8 +183,10 @@ blink_platform_sources("scheduler") {
"//v8", "//v8",
] ]
allow_circular_includes_from = allow_circular_includes_from = [
[ "//third_party/blink/renderer/platform/instrumentation" ] "//third_party/blink/renderer/platform/heap:heap",
"//third_party/blink/renderer/platform/instrumentation",
]
} }
source_set("test_support") { source_set("test_support") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment