Commit 8e503b0b authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/supervised_user.

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug: 809610
Change-Id: I3280d803989a93c67ff0d34b21c409028f8011d5
Reviewed-on: https://chromium-review.googlesource.com/c/1259037
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596635}
parent 226e4913
......@@ -4,6 +4,7 @@
#include "chrome/browser/supervised_user/child_accounts/child_account_service.h"
#include "base/bind.h"
#include "chrome/browser/signin/chrome_signin_client_factory.h"
#include "chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h"
#include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"
......@@ -29,9 +30,9 @@ class ChildAccountServiceTest : public ::testing::Test {
void SetUp() override {
ChromeSigninClientFactory::GetInstance()->SetTestingFactory(
&profile_, &BuildTestSigninClient);
&profile_, base::BindRepeating(&BuildTestSigninClient));
GaiaCookieManagerServiceFactory::GetInstance()->SetTestingFactory(
&profile_, &BuildFakeGaiaCookieManagerService);
&profile_, base::BindRepeating(&BuildFakeGaiaCookieManagerService));
gaia_cookie_manager_service_ = static_cast<FakeGaiaCookieManagerService*>(
GaiaCookieManagerServiceFactory::GetForProfile(&profile_));
}
......
......@@ -9,6 +9,7 @@
#include <memory>
#include <utility>
#include "base/bind.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
......@@ -187,8 +188,9 @@ class SupervisedUserServiceTest : public ::testing::Test {
void SetUp() override {
TestingProfile::Builder builder;
builder.AddTestingFactory(ProfileOAuth2TokenServiceFactory::GetInstance(),
BuildFakeProfileOAuth2TokenService);
builder.AddTestingFactory(
ProfileOAuth2TokenServiceFactory::GetInstance(),
base::BindRepeating(&BuildFakeProfileOAuth2TokenService));
profile_ = builder.Build();
supervised_user_service_ =
SupervisedUserServiceFactory::GetForProfile(profile_.get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment