Commit 8e6168b8 authored by Mark Cogan's avatar Mark Cogan Committed by Commit Bot

[iOS] Fix metrics for "New Window" tools menu item.

The New Window overflow menu item wasn't setting a window origin, so
no metrics were recorded for it. This CL adds the appropriate origin.

Bug: 1143280
Change-Id: I4a85fff19b72d35cbc8d0254086553042fb5d273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505873Reviewed-by: default avatarDavid Jean <djean@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822102}
parent 19dee53b
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "base/notreached.h" #include "base/notreached.h"
#include "base/strings/sys_string_conversions.h" #include "base/strings/sys_string_conversions.h"
#include "components/open_from_clipboard/clipboard_recent_content.h" #include "components/open_from_clipboard/clipboard_recent_content.h"
#include "ios/chrome/browser/chrome_url_constants.h"
#import "ios/chrome/browser/ui/commands/application_commands.h" #import "ios/chrome/browser/ui/commands/application_commands.h"
#import "ios/chrome/browser/ui/commands/browser_commands.h" #import "ios/chrome/browser/ui/commands/browser_commands.h"
#import "ios/chrome/browser/ui/commands/find_in_page_commands.h" #import "ios/chrome/browser/ui/commands/find_in_page_commands.h"
...@@ -133,7 +134,9 @@ const char kManagementPageURL[] = "chrome://management"; ...@@ -133,7 +134,9 @@ const char kManagementPageURL[] = "chrome://management";
break; break;
#endif // !defined(NDEBUG) #endif // !defined(NDEBUG)
case PopupMenuActionOpenNewWindow: case PopupMenuActionOpenNewWindow:
[self.dispatcher openNewWindowWithActivity:nil]; [self.dispatcher openNewWindowWithActivity:ActivityToLoadURL(
WindowActivityToolsOrigin,
GURL(kChromeUINewTabURL))];
break; break;
case PopupMenuActionBookmarks: case PopupMenuActionBookmarks:
RecordAction(UserMetricsAction("MobileMenuAllBookmarks")); RecordAction(UserMetricsAction("MobileMenuAllBookmarks"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment