Web MIDI API renaming: the last step of three step changes

Remove old functions. Now there are no 'SysEx' and 'sysEx' strings
in Web MIDI implementation after this change.

Here are a series of changes on this renaming. 
1. https://codereview.chromium.org/208243014/
2. https://codereview.chromium.org/210003002/
3. this change

BUG=349538
TEST=LayoutTests/webmidi

Review URL: https://codereview.chromium.org/208423016

git-svn-id: svn://svn.chromium.org/blink/trunk@170062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/webmidi/permission.html

@@ -8,10 +8,6 @@
 
 description("Test if sysex permission request is handled.");
 
-// FIXME: remove following workaround once testRunner in Chromium has a new interface.
-if (!testRunner.setMIDISysexPermission)
-    testRunner.setMIDISysexPermission = testRunner.setMIDISysExPermission;
-
 shouldBeDefined("testRunner.setMIDISysexPermission");
 shouldBeDefined("navigator.requestMIDIAccess");
 
@@ -22,7 +18,7 @@ var finishSuccessfully = function () {
     finishJSTest();
 }
 
-var rejectSysEx = function (next) {
+var rejectSysex = function (next) {
     testRunner.setMIDISysexPermission(false);
     promise = navigator.requestMIDIAccess({sysex: true});
     shouldBeDefined("promise");
@@ -39,7 +35,7 @@ var rejectSysEx = function (next) {
     });
 }
 
-var acceptSysEx = function (next) {
+var acceptSysex = function (next) {
     testRunner.setMIDISysexPermission(true);
     promise = navigator.requestMIDIAccess({sysex: true});
     shouldBeDefined("promise");
@@ -60,7 +56,7 @@ var acceptSysEx = function (next) {
     });
 }
 
-rejectSysEx(acceptSysEx);
+rejectSysex(acceptSysex);
 
 </script>
 </body>

third_party/WebKit/LayoutTests/webmidi/send_messages.html

@@ -8,10 +8,6 @@
 
 description("Test if various kinds of MIDI messages can be validated.");
 
-// FIXME: remove following workaround once testRunner in Chromium has a new interface.
-if (!testRunner.setMIDISysexPermission)
-    testRunner.setMIDISysexPermission = testRunner.setMIDISysExPermission;
-
 shouldBeDefined("testRunner.setMIDISysexPermission");
 shouldBeDefined("navigator.requestMIDIAccess");
 

third_party/WebKit/Source/web/MIDIClientProxy.cpp

@@ -46,18 +46,16 @@ MIDIClientProxy::MIDIClientProxy(WebMIDIClient* client)
 
 void MIDIClientProxy::requestSysexPermission(PassRefPtrWillBeRawPtr<MIDIAccess> access)
 {
-    // FIXME: call new function once Chromium implements it.
     if (m_client)
-        m_client->requestSysExPermission(WebMIDIPermissionRequest(access));
+        m_client->requestSysexPermission(WebMIDIPermissionRequest(access));
     else
         access->setSysexEnabled(false);
 }
 
 void MIDIClientProxy::cancelSysexPermissionRequest(MIDIAccess* access)
 {
-    // FIXME: call new function once Chromium implements it.
     if (m_client)
-        m_client->cancelSysExPermissionRequest(WebMIDIPermissionRequest(access));
+        m_client->cancelSysexPermissionRequest(WebMIDIPermissionRequest(access));
 }
 
 } // namespace blink

third_party/WebKit/public/web/WebMIDIClient.h

@@ -39,14 +39,9 @@ public:
     virtual ~WebMIDIClient() { }
 
     // Request a permission to use system exclusive messages. Called when MIDIOptions.sysex is true.
-    // FIXME: Make following new functions pure virtual once Chromium implements them.
-    virtual void requestSysexPermission(const WebMIDIPermissionRequest&) { };
+    virtual void requestSysexPermission(const WebMIDIPermissionRequest&) = 0;
     // Cancel the request since the requesting frame may be moving to a new page.
-    virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) { };
-
-    // FIXME: Remove following old functions once Chromium usess new functions.
-    virtual void requestSysExPermission(const WebMIDIPermissionRequest&) { };
-    virtual void cancelSysExPermissionRequest(const WebMIDIPermissionRequest&) { };
+    virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) = 0;
 };
 
 } // namespace blink

third_party/WebKit/public/web/WebMIDIClientMock.h

@@ -49,18 +49,10 @@ public:
     BLINK_EXPORT void setSysexPermission(bool);
     BLINK_EXPORT void resetMock();
 
-    // FIXME: Remove following function once Chromium stop using it.
-    void setSysExPermission(bool permission) { setSysexPermission(permission); }
-
     // WebMIDIClient
     virtual void requestSysexPermission(const WebMIDIPermissionRequest&) OVERRIDE;
     virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) OVERRIDE;
 
-    // FIXME: Remove following old functions once Chromium uses new functions.
-    virtual void requestSysExPermission(const WebMIDIPermissionRequest& request) { requestSysexPermission(request); }
-    virtual void cancelSysExPermissionRequest(const WebMIDIPermissionRequest& request) { cancelSysexPermissionRequest(request); }
-
-
 private:
     BLINK_EXPORT void reset();