Commit 8eb63210 authored by Nicholas Hollingum's avatar Nicholas Hollingum Committed by Commit Bot

borealis: Add TODOs related to DLC features

Discussed with the DLC team, we're tracking these two FRs from
DLCservice, so ive added TODOs in the relevant parts of the code.

Bug: b/172284265, b/172279567
Change-Id: If46949016defd403f266d3fb766488089657e7af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515804
Auto-Submit: Nic Hollingum <hollingum@google.com>
Reviewed-by: default avatarDaniel Ng <danielng@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#823420}
parent 916bf340
......@@ -161,6 +161,8 @@ void BorealisInstallerImpl::OnDlcInstallationCompleted(
// At this point, the Borealis DLC installation has failed.
InstallationResult result = InstallationResult::kDlcUnknown;
// TODO(b/172284265): Handle the case where a device update is required before
// a DLC can be installed.
if (install_result.error == dlcservice::kErrorInternal) {
LOG(ERROR) << "Something went wrong internally with DlcService.";
result = InstallationResult::kDlcInternal;
......
......@@ -22,6 +22,8 @@ MountDlc::~MountDlc() = default;
void MountDlc::Run(BorealisContext* context,
CompletionStatusCallback callback) {
// TODO(b/172279567): Ensure the DLC is present before trying to install,
// otherwise we will silently download borealis here.
chromeos::DlcserviceClient::Get()->Install(
kBorealisDlcName,
base::BindOnce(&MountDlc::OnMountDlc, weak_factory_.GetWeakPtr(), context,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment