Commit 8f632648 authored by Brian White's avatar Brian White Committed by Commit Bot

Revert "Field crash if histogram bucket creation isn't as expected."

This reverts commit 673081e3.

Reason for revert: Test complete. One day in the field is sufficient.

Original change's description:
> Field crash if histogram bucket creation isn't as expected.
> 
> There are reports from the field that the "maximum" of a histogram
> does not match what was configured.  The working theory is that it is
> due to rounding errors in the creation of exponential buckets.
> Verify this assumption.  If it's behaving wrong, it should crash
> during the creation.
> 
> Bug: 836238
> Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d
> Reviewed-on: https://chromium-review.googlesource.com/1228840
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592128}

TBR=asvitkine@chromium.org,bcwhite@chromium.org

Change-Id: I0c7ecfc65d31aa2d161f1b689a178432a9364e27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836238
Reviewed-on: https://chromium-review.googlesource.com/1233893Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592385}
parent f0252116
......@@ -184,30 +184,6 @@ HistogramBase* Histogram::Factory::Build() {
DCHECK_EQ(minimum_, registered_ranges->range(1));
DCHECK_EQ(maximum_, registered_ranges->range(bucket_count_ - 1));
// Temporary check for https://crbug.com/836238
#if defined(OS_WIN) // Only Windows has a debugger that makes this useful.
if (maximum_ != registered_ranges->range(bucket_count_ - 1)) {
// Create local copies of the parameters to be sure they'll be available
// in the crash dump for the debugger to see.
Sample hash_32 = static_cast<Sample>(HashMetricName(name_));
debug::Alias(&hash_32);
DEBUG_ALIAS_FOR_CSTR(h_name, name_.c_str(), 100);
HistogramType h_type = histogram_type_;
Sample h_min = minimum_;
Sample h_max = maximum_;
uint32_t h_count = bucket_count_;
debug::Alias(&h_type);
debug::Alias(&h_min);
debug::Alias(&h_max);
debug::Alias(&h_count);
uint32_t ranges_min = registered_ranges->range(1);
uint32_t ranges_max = registered_ranges->range(bucket_count_ - 1);
debug::Alias(&ranges_min);
debug::Alias(&ranges_max);
CHECK(false) << name_;
}
#endif
// Try to create the histogram using a "persistent" allocator. As of
// 2016-02-25, the availability of such is controlled by a base::Feature
// that is off by default. If the allocator doesn't exist or if
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment