Skip to content

GitLab

T
tangled
Commit 90365fc7 authored by Zhiyuan Cai's avatar Zhiyuan Cai Committed by Chromium LUCI CQ
Browse files
Options

Add strings for PriceTrackingDialog and PriceDropAlerts message card 

Bug: 1163136, 1166702, 1166704
Change-Id: If1ab00206e17596230ff5874a9d98da896dc15ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629694
Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarYue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844798}
parent 7de890d1
Show whitespace changes
Inline Side-by-side
Showing with 59 additions and 6 deletions
chrome/android/expectations/lint-suppressions.xml
View file @ 90365fc7
...@@ -274,10 +274,19 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint. ...@@ -274,10 +274,19 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<ignore regexp="The resource `R.string.ntp_article_suggestions_section_empty` appears to be unused"/> <ignore regexp="The resource `R.string.ntp_article_suggestions_section_empty` appears to be unused"/>
<!-- 1: TODO(crbug.com/1137985) resource is used in downstream image editor. --> <!-- 1: TODO(crbug.com/1137985) resource is used in downstream image editor. -->
<ignore regexp="The resource `R.string.clear` appears to be unused"/> <ignore regexp="The resource `R.string.clear` appears to be unused"/>
<!-- 3: Temporarily suppressed until impelmentation is ready, see https://crbug.com/1148020 --> <!-- 1: Temporarily suppressed until impelmentation is ready, see https://crbug.com/1166704. -->
<ignore regexp="The resource `R.string.price_drop_spotted_title` appears to be unused"/> <ignore regexp="The resource `R.string.price_drop_spotted_lower_price` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_spotted_content` appears to be unused"/> <!-- 4: Temporarily suppressed until impelmentation is ready, see https://crbug.com/1166702 -->
<ignore regexp="The resource `R.string.price_drop_spotted_show_me` appears to be unused"/> <ignore regexp="The resource `R.string.price_drop_alerts_card_title` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_alerts_card_content` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_alerts_card_settings` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_alerts_card_get_notified` appears to be unused"/>
<!-- 5: Temporarily suppressed until impelmentation is ready, see https://crbug.com/1163136 -->
<ignore regexp="The resource `R.string.price_tracking_settings` appears to be unused"/>
<ignore regexp="The resource `R.string.track_prices_on_tabs` appears to be unused"/>
<ignore regexp="The resource `R.string.track_prices_on_tabs_description` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_alerts` appears to be unused"/>
<ignore regexp="The resource `R.string.price_drop_alerts_description` appears to be unused"/>
<!-- Endnote: Please specify number of suppressions when adding more --> <!-- Endnote: Please specify number of suppressions when adding more -->
</issue> </issue>
<issue id="VectorPath" severity="ignore"/> <issue id="VectorPath" severity="ignore"/>
......
chrome/android/features/tab_ui/java/strings/android_chrome_tab_ui_strings.grd
View file @ 90365fc7
...@@ -379,11 +379,45 @@ ...@@ -379,11 +379,45 @@
Price drop spotted Price drop spotted
</message> </message>
<message name="IDS_PRICE_DROP_SPOTTED_CONTENT" desc="This text shows below 'Price drop spotted'. It describes what will happen when clicking 'Show me' button."> <message name="IDS_PRICE_DROP_SPOTTED_CONTENT" desc="This text shows below 'Price drop spotted'. It describes what will happen when clicking 'Show me' button.">
See which item in your open tabs has a better price See which item in your open tabs has a lower price
</message> </message>
<message name="IDS_PRICE_DROP_SPOTTED_SHOW_ME" desc="This text button shows below 'Price drop spotted'. When user clicks on the text button, it scrolls the users to the first tab that has a price drop."> <message name="IDS_PRICE_DROP_SPOTTED_SHOW_ME" desc="This text button shows below 'Price drop spotted'. When user clicks on the text button, it scrolls the users to the first tab that has a price drop.">
Show me Show me
</message> </message>
<message name="IDS_PRICE_DROP_SPOTTED_LOWER_PRICE" desc="This text shows on the blue tooltip that appears on a tab where we have detected a price drop in that tab. 'Lower' is an adjective.">
Lower price
</message>
<!-- Price Alerts Card strings -->
<message name="IDS_PRICE_DROP_ALERTS_CARD_TITLE" desc="This text shows on the price drop alerts message card if any item in the open tabs has a price drop. It familiarizes users with the feature getting price drop alerts.">
Get alerts for price drops?
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_CONTENT" desc="This text shows below 'Get alerts for price drops?'. It describes what will happen when clicking 'Get notified' button. Placeholder SETTINGS will always be filled with string IDS_PRICE_DROP_ALERTS_CARD_SETTINGS which is 'settings'. We are leaving it as a placeholder to make it clickable.">
You'll get an alert when there's a lower price in an open tab. You can turn off alerts in <ph name="SETTINGS">%1$s<ex>settings</ex></ph>.
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_SETTINGS" desc="This text shows within string IDS_PRICE_DROP_ALERTS_CARD_CONTENT which is 'You'll get an alert when there's a lower price in an open tab. You can turn off alerts in settings'.">
settings
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_GET_NOTIFIED" desc="This text button shows below 'Get alerts for price drops?'. When user clicks on the text button, the price drop notifications feature will be turned on.">
Get notified
</message>
<!-- Price Tracking Settings Dialog strings -->
<message name="IDS_PRICE_TRACKING_SETTINGS" desc="When users click the menu item 'Track prices' in tab switcher, a dialog will pop up and this text is the title of the dialog.">
Price tracking settings
</message>
<message name="IDS_TRACK_PRICES_ON_TABS" desc="This text shows in the price tracking settings dialog. It tells users the switch on the side can be used to turn on/off the 'Track prices on tabs' feature.">
Track prices on tabs
</message>
<message name="IDS_TRACK_PRICES_ON_TABS_DESCRIPTION" desc="This text shows below 'Track prices on tabs'. It describes what will happen when turning on this feature.">
See price drops on your tabs
</message>
<message name="IDS_PRICE_DROP_ALERTS" desc="This text shows in the price tracking settings dialog. It tells users the switch on the side can be used to turn on/off the 'Price drop alerts' feature.">
Price drop alerts
</message>
<message name="IDS_PRICE_DROP_ALERTS_DESCRIPTION" desc="This text shows below 'Price drop alerts'. It describes what will happen when turning on this feature.">
Get notified when prices drop
</message>
</messages> </messages>
</release> </release>
</grit> </grit>
chrome/android/features/tab_ui/java/strings/android_chrome_tab_ui_strings_grd/IDS_PRICE_DROP_SPOTTED_CONTENT.png.sha1
View file @ 90365fc7
457f59642b212f293e9905e669f986512c4c4f11 daa7728f5cd2ebff3383a3130527f8a32187f355
\ No newline at end of file \ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment