Enable "gn check" for //third_party/blink/renderer/platform/instrumentation

It has circular dependencies with platform:platform and
platform/scheduler:scheduler.  They are safe because these targets are
in a single library.

This CL has no behavior changes.

Bug: 800764
Change-Id: I613a6511d5f542b7c59004d99fa405f9c82ae226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397177Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805263}

.gn

@@ -260,7 +260,6 @@ no_check_targets = [
   "//third_party/blink/renderer/modules/webtransport:*",  # 16 errors
   "//third_party/blink/renderer/modules:*",  # 321 errors
   "//third_party/blink/renderer/platform/heap:*",  # 65 errors
-  "//third_party/blink/renderer/platform/instrumentation:*",  # 13 errors
   "//third_party/blink/renderer/platform/loader:*",  # 180 errors
   "//third_party/blink/renderer/platform/network:*",  # 15 errors
   "//third_party/blink/renderer/platform:*",  # 72 errors

third_party/blink/renderer/platform/BUILD.gn

@@ -1561,6 +1561,7 @@ component("platform") {
 
   allow_circular_includes_from = [
     "//third_party/blink/renderer/platform/blob",
+    "//third_party/blink/renderer/platform/instrumentation",
     "//third_party/blink/renderer/platform/scheduler",
   ]
 

third_party/blink/renderer/platform/heap/BUILD.gn

@@ -120,6 +120,7 @@ blink_platform_sources("heap") {
 
   visibility = [
     "//third_party/blink/renderer/platform:platform",
+    "//third_party/blink/renderer/platform/instrumentation:instrumentation",
     "//third_party/blink/renderer/platform/scheduler:scheduler",
   ]
 }

third_party/blink/renderer/platform/instrumentation/BUILD.gn

@@ -46,6 +46,7 @@ blink_platform_sources("instrumentation") {
     "//components/performance_manager/public/mojom:mojom_blink",
     "//services/service_manager/public/cpp",
   ]
+  public_deps = [ "//third_party/blink/renderer/platform/heap:heap" ]
 }
 
 source_set("unit_tests") {
@@ -62,6 +63,7 @@ source_set("unit_tests") {
     "//base/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
+    "//third_party/blink/renderer/platform:platform",
   ]
 
   configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ]

third_party/blink/renderer/platform/platform.gni

@@ -20,9 +20,6 @@ template("blink_platform_sources") {
     # Any target outside platform should instead depend on platform.
     visibility = [ "//third_party/blink/renderer/platform" ]
 
-    assert(
-        !defined(invoker.public_deps),
-        "$target_name's public_deps should be moved to //third_party/blink/renderer/platform:blink_platform_public_deps")
     deps =
         [ "//third_party/blink/renderer/platform:blink_platform_public_deps" ]
     if (defined(invoker.deps)) {

third_party/blink/renderer/platform/scheduler/BUILD.gn

@@ -182,6 +182,9 @@ blink_platform_sources("scheduler") {
     "//third_party/blink/renderer/platform/wtf",
     "//v8",
   ]
+
+  allow_circular_includes_from =
+      [ "//third_party/blink/renderer/platform/instrumentation" ]
 }
 
 source_set("test_support") {