Commit 9146c72c authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

[build] Disable call-graph-profile-sort by default

It currently only applies on Android, but turn it off by default so we actively
opt-in when it starts working on other targets. Follow-up to 9795f362.

(This may or may not mitigate the Win size increase from the latest
clang roll, see the second bug.)

Bug: 1110413, 1112174
Change-Id: I928d9125536b330276fa6557c00475c84ee50a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332591
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794135}
parent cf403f5e
......@@ -694,11 +694,17 @@ config("compiler") {
ldflags += [ "-Wl,--no-rosegment" ]
}
# Don't do call-graph-sorted binary layout on Android, as that increases the
# binary size due to more thunks for long jumps.
if (use_lld && is_android) {
# LLD does call-graph-sorted binary layout by default when profile data is
# present. On Android this increases binary size due to more thinks for long
# jumps. Turn it off by default and enable selectively for targets where it's
# beneficial.
if (use_lld) {
if (is_win) {
ldflags += [ "/call-graph-profile-sort:no" ]
} else {
ldflags += [ "-Wl,--no-call-graph-profile-sort" ]
}
}
# This flag enforces that member pointer base types are complete. It helps
# prevent us from running into problems in the Microsoft C++ ABI (see
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment