Commit 9186bf10 authored by mukai's avatar mukai Committed by Commit bot

Cleanup: remove HomeCardLayoutManager::Delegate.

This class is simply unnecessary.

BUG=None
R=oshima@chromium.org
TEST=athena_unittests passes

Review URL: https://codereview.chromium.org/501183002

Cr-Commit-Position: refs/heads/master@{#291841}
parent c0fb8021
...@@ -72,40 +72,39 @@ gfx::Rect GetBoundsForState(const gfx::Rect& screen_bounds, ...@@ -72,40 +72,39 @@ gfx::Rect GetBoundsForState(const gfx::Rect& screen_bounds,
// vertically. // vertically.
class HomeCardLayoutManager : public aura::LayoutManager { class HomeCardLayoutManager : public aura::LayoutManager {
public: public:
class Delegate { explicit HomeCardLayoutManager()
public: : home_card_(NULL) {}
virtual ~Delegate() {}
virtual HomeCard::State GetState() = 0;
virtual aura::Window* GetNativeWindow() = 0;
};
explicit HomeCardLayoutManager(Delegate* delegate)
: delegate_(delegate) {}
virtual ~HomeCardLayoutManager() {} virtual ~HomeCardLayoutManager() {}
void Layout() { void Layout() {
aura::Window* home_card = delegate_->GetNativeWindow();
// |home_card| could be detached from the root window (e.g. when it is being // |home_card| could be detached from the root window (e.g. when it is being
// destroyed). // destroyed).
if (!home_card || !home_card->GetRootWindow()) if (!home_card_ || !home_card_->IsVisible() || !home_card_->GetRootWindow())
return; return;
{ {
ui::ScopedLayerAnimationSettings settings( ui::ScopedLayerAnimationSettings settings(
home_card->layer()->GetAnimator()); home_card_->layer()->GetAnimator());
settings.SetTweenType(gfx::Tween::EASE_IN_OUT); settings.SetTweenType(gfx::Tween::EASE_IN_OUT);
SetChildBoundsDirect(home_card, GetBoundsForState( SetChildBoundsDirect(home_card_, GetBoundsForState(
home_card->GetRootWindow()->bounds(), delegate_->GetState())); home_card_->GetRootWindow()->bounds(), HomeCard::Get()->GetState()));
} }
} }
private: private:
// aura::LayoutManager: // aura::LayoutManager:
virtual void OnWindowResized() OVERRIDE { Layout(); } virtual void OnWindowResized() OVERRIDE { Layout(); }
virtual void OnWindowAddedToLayout(aura::Window* child) OVERRIDE { Layout(); } virtual void OnWindowAddedToLayout(aura::Window* child) OVERRIDE {
virtual void OnWillRemoveWindowFromLayout(aura::Window* child) OVERRIDE {} if (!home_card_) {
home_card_ = child;
Layout();
}
}
virtual void OnWillRemoveWindowFromLayout(aura::Window* child) OVERRIDE {
if (home_card_ == child)
home_card_ = NULL;
}
virtual void OnWindowRemovedFromLayout(aura::Window* child) OVERRIDE { virtual void OnWindowRemovedFromLayout(aura::Window* child) OVERRIDE {
Layout(); Layout();
} }
...@@ -118,7 +117,7 @@ class HomeCardLayoutManager : public aura::LayoutManager { ...@@ -118,7 +117,7 @@ class HomeCardLayoutManager : public aura::LayoutManager {
SetChildBoundsDirect(child, requested_bounds); SetChildBoundsDirect(child, requested_bounds);
} }
Delegate* delegate_; aura::Window* home_card_;
DISALLOW_COPY_AND_ASSIGN(HomeCardLayoutManager); DISALLOW_COPY_AND_ASSIGN(HomeCardLayoutManager);
}; };
...@@ -400,7 +399,6 @@ class HomeCardView : public views::WidgetDelegateView { ...@@ -400,7 +399,6 @@ class HomeCardView : public views::WidgetDelegateView {
class HomeCardImpl : public HomeCard, class HomeCardImpl : public HomeCard,
public AcceleratorHandler, public AcceleratorHandler,
public HomeCardLayoutManager::Delegate,
public HomeCardGestureManager::Delegate, public HomeCardGestureManager::Delegate,
public WindowManagerObserver, public WindowManagerObserver,
public aura::client::ActivationChangeObserver { public aura::client::ActivationChangeObserver {
...@@ -429,9 +427,6 @@ class HomeCardImpl : public HomeCard, ...@@ -429,9 +427,6 @@ class HomeCardImpl : public HomeCard,
virtual bool OnAcceleratorFired(int command_id, virtual bool OnAcceleratorFired(int command_id,
const ui::Accelerator& accelerator) OVERRIDE; const ui::Accelerator& accelerator) OVERRIDE;
// HomeCardLayoutManager::Delegate:
virtual aura::Window* GetNativeWindow() OVERRIDE;
// HomeCardGestureManager::Delegate: // HomeCardGestureManager::Delegate:
virtual void OnGestureEnded(State final_state) OVERRIDE; virtual void OnGestureEnded(State final_state) OVERRIDE;
virtual void OnGestureProgressed( virtual void OnGestureProgressed(
...@@ -498,7 +493,7 @@ void HomeCardImpl::Init() { ...@@ -498,7 +493,7 @@ void HomeCardImpl::Init() {
ScreenManager::ContainerParams params("HomeCardContainer", CP_HOME_CARD); ScreenManager::ContainerParams params("HomeCardContainer", CP_HOME_CARD);
params.can_activate_children = true; params.can_activate_children = true;
aura::Window* container = ScreenManager::Get()->CreateContainer(params); aura::Window* container = ScreenManager::Get()->CreateContainer(params);
layout_manager_ = new HomeCardLayoutManager(this); layout_manager_ = new HomeCardLayoutManager();
container->SetLayoutManager(layout_manager_); container->SetLayoutManager(layout_manager_);
wm::SetChildWindowVisibilityChangesAnimated(container); wm::SetChildWindowVisibilityChangesAnimated(container);
...@@ -525,7 +520,7 @@ void HomeCardImpl::Init() { ...@@ -525,7 +520,7 @@ void HomeCardImpl::Init() {
activation_client_->AddObserver(this); activation_client_->AddObserver(this);
int work_area_bottom_inset = int work_area_bottom_inset =
GetBoundsForState(GetNativeWindow()->bounds(), GetBoundsForState(home_card_widget_->GetNativeWindow()->bounds(),
HomeCard::VISIBLE_MINIMIZED).height(); HomeCard::VISIBLE_MINIMIZED).height();
AthenaEnv::Get()->SetDisplayWorkAreaInsets( AthenaEnv::Get()->SetDisplayWorkAreaInsets(
gfx::Insets(0, 0, work_area_bottom_inset, 0)); gfx::Insets(0, 0, work_area_bottom_inset, 0));
...@@ -596,13 +591,6 @@ bool HomeCardImpl::OnAcceleratorFired(int command_id, ...@@ -596,13 +591,6 @@ bool HomeCardImpl::OnAcceleratorFired(int command_id,
return true; return true;
} }
aura::Window* HomeCardImpl::GetNativeWindow() {
if (state_ == HIDDEN)
return NULL;
return home_card_widget_ ? home_card_widget_->GetNativeWindow() : NULL;
}
void HomeCardImpl::OnGestureEnded(State final_state) { void HomeCardImpl::OnGestureEnded(State final_state) {
home_card_view_->ClearGesture(); home_card_view_->ClearGesture();
if (state_ != final_state && if (state_ != final_state &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment