Move all [Pass Timeout] tests to SlowTests
See [1] for more context, but many tests are currently marked as flaky-timeout. If the only problem with those tests is that they happen to be a bit slow, and therefore sometimes don't get enough time to run, we shouldn't disable those tests. This CL moves all tests currently marked [Pass Timeout] from TestExpectations to SlowTests, and marks them [Slow]. I will attempt to run the trybots a number of times to check for remaining flakiness, but there's obviously a chance some of these will continue to flake after this CL lands. In that case, the sheriffs will need to re-mark the offending tests as flaky. However, the upside will be that likely many tests will remain enabled and our test coverage will be improved. These changes were made using roughly: $ grep -i "\[ Pass Timeout \]" TextExpectations | sed -e 's/\[ Pass Timeout \]/\[ Slow \]/g' The mechanical changes were edited to remove additional whitespace and comments, and some tests were returned to TestExpectations due to either failures on the CQ, or the fact that they were already present in SlowTests. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1095379#c20 Bug: 1095379 Change-Id: I0bf2a2879234123c5346dfeaecfca7a68e90c019 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#827905}
Showing
Please register or sign in to comment