Skip to content

GitLab

T
tangled
Commit 92199fe2 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot
Browse files
Options

Android: Update cmdline-tools to 3.0 

From v2.1 to v3.0, this is required to use new custom lint checks in
aars' lint.jar files.

Updated baseline accordingly.

Bug: 1142927
Change-Id: Id078b9a7a56c37ed6e40483adbffdeaed63b718a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490990Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarLambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822271}
parent 12e31c82
Hide whitespace changes
Inline Side-by-side
Showing with 165 additions and 107 deletions
DEPS
View file @ 92199fe2
...@@ -784,7 +784,7 @@ deps = { ...@@ -784,7 +784,7 @@ deps = {
}, },
{ {
'package': 'chromium/third_party/android_sdk/public/cmdline-tools', 'package': 'chromium/third_party/android_sdk/public/cmdline-tools',
'version': 'ijpIFSitwBfaEdO9VXBGPqDHUVzPimXy_whw3aHTN9oC', 'version': 'V__2Ycej-H2-6AcXX5A3gi7sIk74SuN44PBm2uC_N1sC',
}, },
], ],
'condition': 'checkout_android_native_support', 'condition': 'checkout_android_native_support',
......
chrome/android/expectations/lint-baseline.xml
View file @ 92199fe2
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<issues format="5" by="lint 4.0.1" client="cli" variant="all" version="4.0.1"> <issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
<issue
id="UnsupportedChromeOsCameraSystemFeature"
message="You should look for any camera available on the device, not just the rear"
errorLine1=" boolean hasCamera = pm.hasSystemFeature(PackageManager.FEATURE_CAMERA);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../base/android/java/src/org/chromium/base/SysUtils.java"
line="160"
column="29"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
...@@ -118,7 +129,7 @@ ...@@ -118,7 +129,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java"
line="477" line="475"
column="30"/> column="30"/>
</issue> </issue>
...@@ -129,7 +140,7 @@ ...@@ -129,7 +140,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java" file="../../android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java"
line="144" line="145"
column="63"/> column="63"/>
</issue> </issue>
...@@ -140,7 +151,7 @@ ...@@ -140,7 +151,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java" file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1284" line="1347"
column="9"/> column="9"/>
</issue> </issue>
...@@ -151,7 +162,7 @@ ...@@ -151,7 +162,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java" file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1285" line="1348"
column="17"/> column="17"/>
</issue> </issue>
...@@ -162,7 +173,7 @@ ...@@ -162,7 +173,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java" file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1781" line="1844"
column="46"/> column="46"/>
</issue> </issue>
...@@ -173,7 +184,7 @@ ...@@ -173,7 +184,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java" file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="2780" line="2843"
column="22"/> column="22"/>
</issue> </issue>
...@@ -404,7 +415,7 @@ ...@@ -404,7 +415,7 @@
errorLine2=" ~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java"
line="215" line="224"
column="55"/> column="55"/>
</issue> </issue>
...@@ -415,7 +426,7 @@ ...@@ -415,7 +426,7 @@
errorLine2=" ~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java"
line="219" line="228"
column="48"/> column="48"/>
</issue> </issue>
...@@ -426,7 +437,7 @@ ...@@ -426,7 +437,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java" file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java"
line="285" line="301"
column="57"/> column="57"/>
</issue> </issue>
...@@ -437,7 +448,7 @@ ...@@ -437,7 +448,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java" file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java"
line="409" line="412"
column="77"/> column="77"/>
</issue> </issue>
...@@ -448,7 +459,7 @@ ...@@ -448,7 +459,7 @@
errorLine2=" ~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="362" line="368"
column="84"/> column="84"/>
</issue> </issue>
...@@ -459,7 +470,7 @@ ...@@ -459,7 +470,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="731" line="757"
column="23"/> column="23"/>
</issue> </issue>
...@@ -481,7 +492,7 @@ ...@@ -481,7 +492,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java"
line="770" line="783"
column="67"/> column="67"/>
</issue> </issue>
...@@ -503,7 +514,7 @@ ...@@ -503,7 +514,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java"
line="259" line="260"
column="36"/> column="36"/>
</issue> </issue>
...@@ -514,7 +525,7 @@ ...@@ -514,7 +525,7 @@
errorLine2=" ~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionServiceImpl.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionServiceImpl.java"
line="107" line="104"
column="21"/> column="21"/>
</issue> </issue>
...@@ -573,17 +584,6 @@ ...@@ -573,17 +584,6 @@
column="42"/> column="42"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return FeedConfiguration.getFeedServerEndpoint();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedDebuggingBridge.java"
line="24"
column="34"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -598,12 +598,12 @@ ...@@ -598,12 +598,12 @@
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
errorLine1=" IncognitoNotificationService.getRemoveAllIncognitoTabsIntent(" errorLine1=" IncognitoNotificationServiceImpl.getRemoveAllIncognitoTabsIntent("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java"
line="56" line="56"
column="62"/> column="66"/>
</issue> </issue>
<issue <issue
...@@ -646,7 +646,7 @@ ...@@ -646,7 +646,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="108" line="112"
column="20"/> column="20"/>
</issue> </issue>
...@@ -657,7 +657,7 @@ ...@@ -657,7 +657,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="127" line="131"
column="42"/> column="42"/>
</issue> </issue>
...@@ -668,7 +668,7 @@ ...@@ -668,7 +668,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="141" line="145"
column="20"/> column="20"/>
</issue> </issue>
...@@ -712,7 +712,7 @@ ...@@ -712,7 +712,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java"
line="328" line="302"
column="35"/> column="35"/>
</issue> </issue>
...@@ -734,7 +734,7 @@ ...@@ -734,7 +734,7 @@
errorLine2=" ~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java"
line="322" line="321"
column="36"/> column="36"/>
</issue> </issue>
...@@ -745,7 +745,7 @@ ...@@ -745,7 +745,7 @@
errorLine2=" ~~~~~~~~"> errorLine2=" ~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java"
line="350" line="349"
column="50"/> column="50"/>
</issue> </issue>
...@@ -800,7 +800,7 @@ ...@@ -800,7 +800,7 @@
errorLine2=" ~~~~~~~"> errorLine2=" ~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java"
line="523" line="522"
column="22"/> column="22"/>
</issue> </issue>
...@@ -877,7 +877,7 @@ ...@@ -877,7 +877,7 @@
errorLine2=" ~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java"
line="318" line="325"
column="20"/> column="20"/>
</issue> </issue>
...@@ -888,7 +888,7 @@ ...@@ -888,7 +888,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java"
line="63" line="64"
column="25"/> column="25"/>
</issue> </issue>
...@@ -899,7 +899,7 @@ ...@@ -899,7 +899,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ShareSheetPropertyModelBuilder.java" file="../../chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ShareSheetPropertyModelBuilder.java"
line="202" line="212"
column="25"/> column="25"/>
</issue> </issue>
...@@ -1053,7 +1053,7 @@ ...@@ -1053,7 +1053,7 @@
errorLine2=" ~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java"
line="1568" line="1554"
column="74"/> column="74"/>
</issue> </issue>
...@@ -1064,7 +1064,7 @@ ...@@ -1064,7 +1064,7 @@
errorLine2=" ~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarCoordinator.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarCoordinator.java"
line="604" line="634"
column="31"/> column="31"/>
</issue> </issue>
...@@ -1086,7 +1086,7 @@ ...@@ -1086,7 +1086,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivityCoordinator.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivityCoordinator.java"
line="54" line="56"
column="70"/> column="70"/>
</issue> </issue>
...@@ -1097,7 +1097,7 @@ ...@@ -1097,7 +1097,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java" file="../../android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java"
line="968" line="972"
column="58"/> column="58"/>
</issue> </issue>
...@@ -1108,7 +1108,7 @@ ...@@ -1108,7 +1108,7 @@
errorLine2=" ~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~">
<location <location
file="../../android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java" file="../../android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java"
line="1824" line="1828"
column="29"/> column="29"/>
</issue> </issue>
...@@ -1130,7 +1130,7 @@ ...@@ -1130,7 +1130,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java" file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java"
line="164" line="70"
column="18"/> column="18"/>
</issue> </issue>
...@@ -1141,7 +1141,7 @@ ...@@ -1141,7 +1141,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java" file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java"
line="188" line="88"
column="30"/> column="30"/>
</issue> </issue>
...@@ -1152,7 +1152,7 @@ ...@@ -1152,7 +1152,7 @@
errorLine2=" ^"> errorLine2=" ^">
<location <location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java" file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java"
line="243" line="143"
column="18"/> column="18"/>
</issue> </issue>
...@@ -1225,23 +1225,23 @@ ...@@ -1225,23 +1225,23 @@
<issue <issue
id="Autofill" id="Autofill"
message="Missing `autofillHints` attribute" message="Missing `autofillHints` attribute"
errorLine1=" &lt;EditText" errorLine1=" &lt;EditText"
errorLine2=" ~~~~~~~~"> errorLine2=" ~~~~~~~~">
<location <location
file="../../chrome/browser/password_check/android/java/res/layout/password_check_edit_fragment.xml" file="../../chrome/browser/password_check/android/java/res/layout/password_check_edit_fragment.xml"
line="27" line="31"
column="10"/> column="14"/>
</issue> </issue>
<issue <issue
id="Autofill" id="Autofill"
message="Missing `autofillHints` attribute" message="Missing `autofillHints` attribute"
errorLine1=" &lt;EditText" errorLine1=" &lt;EditText"
errorLine2=" ~~~~~~~~"> errorLine2=" ~~~~~~~~">
<location <location
file="../../chrome/browser/password_check/android/java/res/layout/password_check_edit_fragment.xml" file="../../chrome/browser/password_check/android/java/res/layout/password_check_edit_fragment.xml"
line="47" line="52"
column="10"/> column="14"/>
</issue> </issue>
<issue <issue
...@@ -1251,7 +1251,7 @@ ...@@ -1251,7 +1251,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/accessibility_tab_switcher/AccessibilityTabModelListItem.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/accessibility_tab_switcher/AccessibilityTabModelListItem.java"
line="453" line="456"
column="20"/> column="20"/>
</issue> </issue>
...@@ -1262,7 +1262,7 @@ ...@@ -1262,7 +1262,7 @@
errorLine2=" ^"> errorLine2=" ^">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java"
line="215" line="193"
column="46"/> column="46"/>
</issue> </issue>
...@@ -1339,7 +1339,7 @@ ...@@ -1339,7 +1339,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java"
line="639" line="652"
column="20"/> column="20"/>
</issue> </issue>
...@@ -1354,17 +1354,6 @@ ...@@ -1354,17 +1354,6 @@
column="20"/> column="20"/>
</issue> </issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `InterceptTouchLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java"
line="126"
column="24"/>
</issue>
<issue <issue
id="ClickableViewAccessibility" id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`" message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
...@@ -1482,7 +1471,7 @@ ...@@ -1482,7 +1471,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButton.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButton.java"
line="76" line="77"
column="9"/> column="9"/>
</issue> </issue>
...@@ -1548,7 +1537,7 @@ ...@@ -1548,7 +1537,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameView.java" file="../../components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameView.java"
line="108" line="107"
column="20"/> column="20"/>
</issue> </issue>
...@@ -1563,17 +1552,6 @@ ...@@ -1563,17 +1552,6 @@
column="20"/> column="20"/>
</issue> </issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ScrollingBottomViewResourceFrameLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/ScrollingBottomViewResourceFrameLayout.java"
line="63"
column="20"/>
</issue>
<issue <issue
id="ClickableViewAccessibility" id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected" message="`onTouch` lambda should call `View#performClick` when a click is detected"
...@@ -1585,17 +1563,6 @@ ...@@ -1585,17 +1563,6 @@
column="46"/> column="46"/>
</issue> </issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mMenuButton.getImageButton().setOnTouchListener(appMenuButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TabSwitcherModeTTPhone.java"
line="188"
column="9"/>
</issue>
<issue <issue
id="ClickableViewAccessibility" id="ClickableViewAccessibility"
message="Custom view `TextEditorHandleView` overrides `onTouchEvent` but not `performClick`" message="Custom view `TextEditorHandleView` overrides `onTouchEvent` but not `performClick`"
...@@ -1603,7 +1570,7 @@ ...@@ -1603,7 +1570,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../clank/browser/image_editor/internal/java/src/org/chromium/chrome/browser/image_editor/text/TextEditorHandleView.java" file="../../clank/browser/image_editor/internal/java/src/org/chromium/chrome/browser/image_editor/text/TextEditorHandleView.java"
line="151" line="181"
column="20"/> column="20"/>
</issue> </issue>
...@@ -1625,7 +1592,7 @@ ...@@ -1625,7 +1592,7 @@
errorLine2=" ~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java" file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java"
line="505" line="499"
column="20"/> column="20"/>
</issue> </issue>
...@@ -1669,7 +1636,7 @@ ...@@ -1669,7 +1636,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml" file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml"
line="48" line="49"
column="17"/> column="17"/>
</issue> </issue>
...@@ -1680,7 +1647,7 @@ ...@@ -1680,7 +1647,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml" file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml"
line="72" line="73"
column="17"/> column="17"/>
</issue> </issue>
...@@ -1691,7 +1658,7 @@ ...@@ -1691,7 +1658,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml" file="../../components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml"
line="96" line="97"
column="17"/> column="17"/>
</issue> </issue>
...@@ -1797,12 +1764,12 @@ ...@@ -1797,12 +1764,12 @@
<issue <issue
id="KeyboardInaccessibleWidget" id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;" message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;" errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../clank/browser/image_editor/internal/java/res/layout/line_tool_color_item.xml" file="../../clank/browser/image_editor/internal/java/res/layout/line_tool_color_item.xml"
line="16" line="17"
column="9"/> column="5"/>
</issue> </issue>
<issue <issue
...@@ -1812,7 +1779,7 @@ ...@@ -1812,7 +1779,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../components/browser_ui/photo_picker/android/java/res/layout/photo_picker_dialog.xml" file="../../components/browser_ui/photo_picker/android/java/res/layout/photo_picker_dialog.xml"
line="36" line="38"
column="9"/> column="9"/>
</issue> </issue>
...@@ -1834,7 +1801,7 @@ ...@@ -1834,7 +1801,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location <location
file="../../chrome/android/java/res/layout/share_sheet_item.xml" file="../../chrome/android/java/res/layout/share_sheet_item.xml"
line="10" line="9"
column="5"/> column="5"/>
</issue> </issue>
......
chrome/android/expectations/lint-suppressions.xml
View file @ 92199fe2
...@@ -135,6 +135,8 @@ Still reading? ...@@ -135,6 +135,8 @@ Still reading?
<issue id="PrivateApi" severity="ignore"/> <issue id="PrivateApi" severity="ignore"/>
<!-- Chrome is a system app. --> <!-- Chrome is a system app. -->
<issue id="ProtectedPermissions" severity="ignore"/> <issue id="ProtectedPermissions" severity="ignore"/>
<!-- Android 11+ package visibility: g.co/dev/packagevisibility -->
<issue id="QueryAllPackagesPermission" severity="ignore"/>
<issue id="RestrictedApi"> <issue id="RestrictedApi">
<!-- Chrome uses these GMS core APIs. --> <!-- Chrome uses these GMS core APIs. -->
<ignore regexp="is marked as internal and should not be accessed from apps"/> <ignore regexp="is marked as internal and should not be accessed from apps"/>
...@@ -145,6 +147,8 @@ Still reading? ...@@ -145,6 +147,8 @@ Still reading?
<issue id="RtlCompat" severity="ignore"/> <issue id="RtlCompat" severity="ignore"/>
<issue id="RtlEnabled" severity="ignore"/> <issue id="RtlEnabled" severity="ignore"/>
<issue id="RtlSymmetry" severity="ignore"/> <issue id="RtlSymmetry" severity="ignore"/>
<!-- Android 10+ WRITE_EXTERNAL_STORAGE changed meaning. -->
<issue id="ScopedStorage" severity="ignore"/>
<issue id="SetJavaScriptEnabled" severity="ignore"/> <issue id="SetJavaScriptEnabled" severity="ignore"/>
<issue id="SignatureOrSystemPermissions" severity="ignore"/> <issue id="SignatureOrSystemPermissions" severity="ignore"/>
<issue id="StaticFieldLeak"> <issue id="StaticFieldLeak">
......
chrome/android/java/src/org/chromium/chrome/browser/policy/EnterpriseInfo.java
View file @ 92199fe2
...@@ -84,6 +84,7 @@ public class EnterpriseInfo { ...@@ -84,6 +84,7 @@ public class EnterpriseInfo {
/** /**
* Returns, via callback, whether the device has a device owner or a profile owner. * Returns, via callback, whether the device has a device owner or a profile owner.
*/ */
@SuppressWarnings("QueryPermissionsNeeded")
public void getDeviceEnterpriseInfo(Callback<OwnedState> callback) { public void getDeviceEnterpriseInfo(Callback<OwnedState> callback) {
// AsyncTask requires being called from UI thread. // AsyncTask requires being called from UI thread.
ThreadUtils.assertOnUiThread(); ThreadUtils.assertOnUiThread();
......
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkHandlerDelegate.java
View file @ 92199fe2
...@@ -56,6 +56,7 @@ public class WebApkHandlerDelegate { ...@@ -56,6 +56,7 @@ public class WebApkHandlerDelegate {
* Calls the native WebApkHandlerDelegate with information for each installed WebAPK. * Calls the native WebApkHandlerDelegate with information for each installed WebAPK.
*/ */
@CalledByNative @CalledByNative
@SuppressWarnings("QueryPermissionsNeeded")
public void retrieveWebApks() { public void retrieveWebApks() {
if (mNativePointer == 0) { if (mNativePointer == 0) {
return; return;
......
components/cronet/android/BUILD.gn
View file @ 92199fe2
...@@ -1015,6 +1015,7 @@ if (!is_component_build) { ...@@ -1015,6 +1015,7 @@ if (!is_component_build) {
# it depends on basically all source files. # it depends on basically all source files.
enable_lint = true enable_lint = true
lint_suppressions_file = "lint-suppressions.xml" lint_suppressions_file = "lint-suppressions.xml"
lint_baseline_file = "lint-baseline.xml"
# Still needs to support Jelly Bean. See crbug.com/922656. # Still needs to support Jelly Bean. See crbug.com/922656.
lint_min_sdk_version = 16 lint_min_sdk_version = 16
......
components/cronet/android/lint-baseline.xml 0 → 100644
View file @ 92199fe2
<?xml version="1.0" encoding="UTF-8"?>
<issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
<issue
id="ScopedStorage"
message="WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 10+"
errorLine1=" &lt;uses-permission android:name=&quot;android.permission.WRITE_EXTERNAL_STORAGE&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="gen/components/cronet/android/cronet_test_instrumentation_apk__test_apk__lint/../../components/cronet/android/test/javatests/AndroidManifest.xml"
line="12"
column="34"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="As of Android 11, this method no longer returns information about all apps; \&#xA;see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.getInstalledPackages(flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="115"
column="25"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="As of Android 11, this method no longer returns information about all apps; \&#xA;see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.getInstalledApplications(flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="210"
column="25"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="Consider adding a `&lt;queries>` declaration to your manifest when calling this \&#xA;method; see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.queryIntentActivities(intent, flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="240"
column="25"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="Consider adding a `&lt;queries>` declaration to your manifest when calling this \&#xA;method; see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.queryBroadcastReceivers(intent, flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="251"
column="25"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="Consider adding a `&lt;queries>` declaration to your manifest when calling this \&#xA;method; see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.queryIntentServices(intent, flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="261"
column="25"/>
</issue>
<issue
id="QueryPermissionsNeeded"
message="Consider adding a `&lt;queries>` declaration to your manifest when calling this \&#xA;method; see https://g.co/dev/packagevisibility for details"
errorLine1=" return mWrapped.queryContentProviders(processName, uid, flags);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"
line="276"
column="25"/>
</issue>
</issues>
components/webapk/android/libs/client/src/org/chromium/components/webapk/lib/client/WebApkValidator.java
View file @ 92199fe2
...@@ -364,6 +364,7 @@ public class WebApkValidator { ...@@ -364,6 +364,7 @@ public class WebApkValidator {
* @param manifestUrl The URL of the manifest that was used to generate the WebAPK. * @param manifestUrl The URL of the manifest that was used to generate the WebAPK.
* @return The WebAPK's package name if installed, or null otherwise. * @return The WebAPK's package name if installed, or null otherwise.
*/ */
@SuppressWarnings("QueryPermissionsNeeded")
public static @Nullable String queryBoundWebApkForManifestUrl( public static @Nullable String queryBoundWebApkForManifestUrl(
Context context, String manifestUrl) { Context context, String manifestUrl) {
assert manifestUrl != null; assert manifestUrl != null;
......
remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java
View file @ 92199fe2
...@@ -82,6 +82,7 @@ public abstract class ChromotingUtil { ...@@ -82,6 +82,7 @@ public abstract class ChromotingUtil {
* @param intent The (implicit) intent to launch. * @param intent The (implicit) intent to launch.
* @return True if the intent was resolved. * @return True if the intent was resolved.
*/ */
@SuppressWarnings("QueryPermissionsNeeded")
public static boolean startActivitySafely(Context context, Intent intent) { public static boolean startActivitySafely(Context context, Intent intent) {
if (intent.resolveActivity(context.getPackageManager()) == null) { if (intent.resolveActivity(context.getPackageManager()) == null) {
Log.w(TAG, "Unable to resolve activity for: %s", intent); Log.w(TAG, "Unable to resolve activity for: %s", intent);
......
third_party/android_sdk/README.chromium
View file @ 92199fe2
...@@ -2,7 +2,7 @@ Name: Android SDK ...@@ -2,7 +2,7 @@ Name: Android SDK
URL: http://developer.android.com/sdk/index.html URL: http://developer.android.com/sdk/index.html
Version: 30 Version: 30
Android SDK Build-tools 30.0.1 Android SDK Build-tools 30.0.1
Android SDK Command-line Tools 2.1 Android SDK Command-line Tools 3.0
Android SDK Emulator 30.0.12 Android SDK Emulator 30.0.12
Android SDK Platform-tools 30.0.3 Android SDK Platform-tools 30.0.3
Android SDK Platform API 30 Android SDK Platform API 30
......
ui/android/java/src/org/chromium/ui/base/Clipboard.java
View file @ 92199fe2
...@@ -424,6 +424,7 @@ public class Clipboard implements ClipboardManager.OnPrimaryClipChangedListener ...@@ -424,6 +424,7 @@ public class Clipboard implements ClipboardManager.OnPrimaryClipChangedListener
* system. But on Android O, sharing images/files needs to grant permission to each app/packages * system. But on Android O, sharing images/files needs to grant permission to each app/packages
* individually. Note: Don't forget to revoke the permission once the clipboard is updated. * individually. Note: Don't forget to revoke the permission once the clipboard is updated.
*/ */
@SuppressWarnings("QueryPermissionsNeeded")
private void grantUriPermission(@NonNull Uri uri) { private void grantUriPermission(@NonNull Uri uri) {
if ((Build.VERSION.SDK_INT != Build.VERSION_CODES.O if ((Build.VERSION.SDK_INT != Build.VERSION_CODES.O
&& Build.VERSION.SDK_INT != Build.VERSION_CODES.O_MR1) && Build.VERSION.SDK_INT != Build.VERSION_CODES.O_MR1)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment