Commit 93129a77 authored by Kevin McNee's avatar Kevin McNee Committed by Commit Bot

Disable guest view tests flaking under Lacros

Bug: 1033009, 1119576
Change-Id: Ia0f1a0989955340b3e383f51ba268ccf69eeb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385784
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803232}
parent d94052ab
......@@ -12,6 +12,7 @@
#include "base/test/test_timeouts.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "build/lacros_buildflags.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
......@@ -269,8 +270,8 @@ class StubDevToolsAgentHostClient : public content::DevToolsAgentHostClient {
} // namespace
// Flaky on ChromeOS (https://crbug.com/1033009)
#if defined(OS_CHROMEOS)
// Flaky on ChromeOS and Lacros (https://crbug.com/1033009)
#if defined(OS_CHROMEOS) || BUILDFLAG(IS_LACROS)
#define MAYBE_GuestDevToolsReloadsEmbedder DISABLED_GuestDevToolsReloadsEmbedder
#else
#define MAYBE_GuestDevToolsReloadsEmbedder GuestDevToolsReloadsEmbedder
......
......@@ -13,6 +13,7 @@
#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "build/lacros_buildflags.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_test.h"
#include "chrome/test/base/interactive_test_utils.h"
......@@ -144,7 +145,13 @@ void WaitForFullscreenAnimation() {
} // namespace
IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, EscapeExitsFullscreen) {
// TODO(1119576): Flaky under Lacros.
#if BUILDFLAG(IS_LACROS)
#define MAYBE_EscapeExitsFullscreen DISABLED_EscapeExitsFullscreen
#else
#define MAYBE_EscapeExitsFullscreen EscapeExitsFullscreen
#endif
IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, MAYBE_EscapeExitsFullscreen) {
// Use the testing subclass of MimeHandlerViewGuest.
GetGuestViewManager()->RegisterTestGuestViewType<MimeHandlerViewGuest>(
base::BindRepeating(&TestMimeHandlerViewGuest::Create));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment