Commit 9391400e authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

[iOS] Add flag for the new error page workflow

Bug: 991608
Change-Id: I7f5c8481309bf2f3be8d98586746d7db1e43f4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914387
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: default avatarYi Su <mrsuyi@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715248}
parent 536bff5d
...@@ -565,6 +565,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -565,6 +565,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
{"force-unstacked-tabstrip", flag_descriptions::kForceUnstackedTabstripName, {"force-unstacked-tabstrip", flag_descriptions::kForceUnstackedTabstripName,
flag_descriptions::kForceUnstackedTabstripDescription, flags_ui::kOsIos, flag_descriptions::kForceUnstackedTabstripDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kForceUnstackedTabstrip)}, FEATURE_VALUE_TYPE(kForceUnstackedTabstrip)},
{"use-js-error-page", flag_descriptions::kUseJSForErrorPageName,
flag_descriptions::kUseJSForErrorPageDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(web::features::kUseJSForErrorPage)},
}; };
// Add all switches from experimental flags to |command_line|. // Add all switches from experimental flags to |command_line|.
......
...@@ -179,6 +179,10 @@ const char kEnableClipboardProviderTextSuggestionsName[] = ...@@ -179,6 +179,10 @@ const char kEnableClipboardProviderTextSuggestionsName[] =
const char kEnableClipboardProviderTextSuggestionsDescription[] = const char kEnableClipboardProviderTextSuggestionsDescription[] =
"Enable suggesting a search for text copied to the clipboard"; "Enable suggesting a search for text copied to the clipboard";
const char kUseJSForErrorPageName[] = "Enable new error page workflow";
const char kUseJSForErrorPageDescription[] =
"Use JavaScript for the error pages";
const char kEnablePersistentDownloadsName[] = "Enable persistent downloads"; const char kEnablePersistentDownloadsName[] = "Enable persistent downloads";
const char kEnablePersistentDownloadsDescription[] = const char kEnablePersistentDownloadsDescription[] =
"Enables the new, experimental implementation of persistent downloads"; "Enables the new, experimental implementation of persistent downloads";
......
...@@ -149,6 +149,10 @@ extern const char kEnableClipboardProviderImageSuggestionsDescription[]; ...@@ -149,6 +149,10 @@ extern const char kEnableClipboardProviderImageSuggestionsDescription[];
extern const char kEnableClipboardProviderTextSuggestionsName[]; extern const char kEnableClipboardProviderTextSuggestionsName[];
extern const char kEnableClipboardProviderTextSuggestionsDescription[]; extern const char kEnableClipboardProviderTextSuggestionsDescription[];
// Title and description for the flag to enable the new error page workflow.
extern const char kUseJSForErrorPageName[];
extern const char kUseJSForErrorPageDescription[];
// Title and description for the flag to enable persistent downloads. // Title and description for the flag to enable persistent downloads.
extern const char kEnablePersistentDownloadsName[]; extern const char kEnablePersistentDownloadsName[];
extern const char kEnablePersistentDownloadsDescription[]; extern const char kEnablePersistentDownloadsDescription[];
......
...@@ -48,6 +48,9 @@ extern const base::Feature kLogLoadStartedInDidStartNavigation; ...@@ -48,6 +48,9 @@ extern const base::Feature kLogLoadStartedInDidStartNavigation;
// Feature flag enabling persistent downloads. // Feature flag enabling persistent downloads.
extern const base::Feature kEnablePersistentDownloads; extern const base::Feature kEnablePersistentDownloads;
// Feature flag for the new error page workflow, using JavaScript.
extern const base::Feature kUseJSForErrorPage;
// Use WKWebView.loading to update WebState::IsLoading. // Use WKWebView.loading to update WebState::IsLoading.
// TODO(crbug.com/1006012): Clean up this flag after experiment. // TODO(crbug.com/1006012): Clean up this flag after experiment.
bool UseWKWebViewLoading(); bool UseWKWebViewLoading();
......
...@@ -44,6 +44,9 @@ const base::Feature kLogLoadStartedInDidStartNavigation{ ...@@ -44,6 +44,9 @@ const base::Feature kLogLoadStartedInDidStartNavigation{
const base::Feature kEnablePersistentDownloads{ const base::Feature kEnablePersistentDownloads{
"EnablePersistentDownloads", base::FEATURE_DISABLED_BY_DEFAULT}; "EnablePersistentDownloads", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kUseJSForErrorPage{"UseJSForErrorPage",
base::FEATURE_DISABLED_BY_DEFAULT};
// The feature kUseWKWebViewLoading will change the CPM if // The feature kUseWKWebViewLoading will change the CPM if
// kLogLoadStartedInDidStartNavigation is not enabled, so // kLogLoadStartedInDidStartNavigation is not enabled, so
// kLogLoadStartedInDidStartNavigation is required. The feature flag // kLogLoadStartedInDidStartNavigation is required. The feature flag
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment