Commit 94c63651 authored by Trevor Perrier's avatar Trevor Perrier Committed by Commit Bot

[Android] Add logging for AppLocaleUtils

This CL adds some simple logging in AppLocaleUtils to observe what
language splits are available to the application and what the override
locale should be.

Bug: 1128698
Change-Id: I95190ea9779cb562b3eea6b50f91e34b29cf1e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453954Reviewed-by: default avatarMegan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814426}
parent 6a99cb1e
...@@ -15,6 +15,7 @@ import com.google.android.play.core.splitinstall.SplitInstallRequest; ...@@ -15,6 +15,7 @@ import com.google.android.play.core.splitinstall.SplitInstallRequest;
import org.chromium.base.BundleUtils; import org.chromium.base.BundleUtils;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys; import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager; import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
...@@ -27,6 +28,8 @@ import java.util.Locale; ...@@ -27,6 +28,8 @@ import java.util.Locale;
public class AppLocaleUtils { public class AppLocaleUtils {
private AppLocaleUtils(){}; private AppLocaleUtils(){};
private static final String TAG = "AppLocale";
/** /**
* Return true if languageName is the same as the current application override * Return true if languageName is the same as the current application override
* language stored preference. * language stored preference.
...@@ -76,7 +79,11 @@ public class AppLocaleUtils { ...@@ -76,7 +79,11 @@ public class AppLocaleUtils {
*/ */
public static void maybeInstallActivitySplitCompat(Context context) { public static void maybeInstallActivitySplitCompat(Context context) {
if (GlobalAppLocaleController.getInstance().isOverridden() && BundleUtils.isBundle()) { if (GlobalAppLocaleController.getInstance().isOverridden() && BundleUtils.isBundle()) {
Log.i(TAG, "maybeInstallActivitySplit isOverridden: %s isBundle: %s",
GlobalAppLocaleController.getInstance().isOverridden(), BundleUtils.isBundle());
SplitCompat.installActivity(context); SplitCompat.installActivity(context);
Log.i(TAG, "Override Locale: %s", getAppLanguagePref());
logInstalledLanguages();
} }
} }
...@@ -95,5 +102,21 @@ public class AppLocaleUtils { ...@@ -95,5 +102,21 @@ public class AppLocaleUtils {
.build(); .build();
splitInstallManager.startInstall(installRequest); splitInstallManager.startInstall(installRequest);
} }
logInstalledLanguages();
}
/**
* Log list of installed languages
*/
private static void logInstalledLanguages() {
if (BundleUtils.isBundle()) {
SplitInstallManager splitInstallManager =
SplitInstallManagerFactory.create(ContextUtils.getApplicationContext());
Log.i(TAG, "Installed Languages: %s",
TextUtils.join(", ", splitInstallManager.getInstalledLanguages()));
} else {
Log.i(TAG, "Installed Languages: None - not a bundle");
}
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment