[NTP] Move tooltip from pencil icon to button.

Move the aria-label and title from the pencil icon to the whole button.
Also combine customizeBackground and customizeThisPage strings as they
are the same.

Bug: 976217
Change-Id: Ia18620e6c69e81a64ce1020d51f7f5c18e62f99a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704390Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678325}

chrome/app/generated_resources.grd

@@ -4985,9 +4985,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
       <message name="IDS_NTP_CONFIRM_MSG_RESTORE_DEFAULTS" desc="The text label of the restore default shortcuts button when editing a custom link. (On the New Tab Page)">
         Restore default shortcuts
       </message>
-      <message name="IDS_NTP_CUSTOM_BG_CUSTOMIZE_BACKGROUND" desc="The title and aria-label for the tooltip for background customization. (On the New Tab Page)">
-        Customize this page
-      </message>
       <message name="IDS_NTP_CUSTOM_BG_CHROME_WALLPAPERS" desc="The text label of the Chrome backgrounds option for background customization.(On the New Tab Page)">
         Chrome backgrounds
       </message>

chrome/app/generated_resources_grd/IDS_NTP_CUSTOM_BG_CUSTOMIZE_BACKGROUND.png.sha1

-32af17f468186a40fb77e59126316f966d369ef1
\ No newline at end of file

chrome/browser/resources/local_ntp/customize.js

@@ -1403,7 +1403,7 @@ customize.init = function(showErrorNotification, hideCustomLinkNotification) {
   const menu = $(customize.IDS.MENU);
 
   $(customize.IDS.OPTIONS_TITLE).textContent =
-      configData.translatedStrings.customizeBackground;
+      configData.translatedStrings.customizeThisPage;
 
   if (configData.richerPicker) {
     // Store the main menu title so it can be restored if needed.
@@ -1411,12 +1411,12 @@ customize.init = function(showErrorNotification, hideCustomLinkNotification) {
         $(customize.IDS.MENU_TITLE).textContent;
   }
 
-  $(customize.IDS.EDIT_BG_ICON)
+  $(customize.IDS.EDIT_BG)
       .setAttribute(
           'aria-label', configData.translatedStrings.customizeThisPage);
 
-  $(customize.IDS.EDIT_BG_ICON)
-      .setAttribute('title', configData.translatedStrings.customizeBackground);
+  $(customize.IDS.EDIT_BG)
+      .setAttribute('title', configData.translatedStrings.customizeThisPage);
 
   // Selecting a local image for the background should close the picker.
   if (configData.richerPicker) {

chrome/browser/resources/local_ntp/externs.js

@@ -373,7 +373,6 @@ configData.translatedStrings.clickToViewDoodle;
 configData.translatedStrings.connectionError;
 configData.translatedStrings.connectionErrorNoPeriod;
 configData.translatedStrings.copyLink;
-configData.translatedStrings.customizeBackground;
 configData.translatedStrings.customizeButtonLabel;
 configData.translatedStrings.customizeThisPage;
 configData.translatedStrings.dailyRefresh;

chrome/browser/search/local_ntp_source.cc

@@ -194,8 +194,6 @@ std::unique_ptr<base::DictionaryValue> GetTranslatedStrings(bool is_google) {
     // Custom Backgrounds
     AddString(translated_strings.get(), "customizeButtonLabel",
               IDS_NTP_CUSTOMIZE_BUTTON_LABEL);
-    AddString(translated_strings.get(), "customizeBackground",
-              IDS_NTP_CUSTOM_BG_CUSTOMIZE_BACKGROUND);
     AddString(translated_strings.get(), "defaultWallpapers",
               IDS_NTP_CUSTOM_BG_CHROME_WALLPAPERS);
     AddString(translated_strings.get(), "uploadImage",