Commit 96fad00d authored by schenney's avatar schenney Committed by Commit bot

Remove a pointless assert that fails with overflowed values

It turns out that
roundedIntPoint(LayoutUnit::max()) != LayoutUNit::max()
so disable the assert in BackgroundImageGeometry that is really just
checking that we have pixel snapped the phase. We don't check any other
values for pixel snapping, so there's no reason to keep checking phase.

And there's no danger to having an unrounded value here. Nothing breaks.

R=fmalita@chromium.org
BUG=626745

Review-Url: https://codereview.chromium.org/2180433002
Cr-Commit-Position: refs/heads/master@{#407255}
parent e58034e6
...@@ -418,7 +418,6 @@ void BackgroundImageGeometry::calculate(const LayoutBoxModelObject& obj, const L ...@@ -418,7 +418,6 @@ void BackgroundImageGeometry::calculate(const LayoutBoxModelObject& obj, const L
m_destRect.intersect(paintRect); m_destRect.intersect(paintRect);
// Snap as-yet unsnapped values. // Snap as-yet unsnapped values.
DCHECK(m_phase == LayoutPoint(roundedIntPoint(m_phase)));
setDestRect(LayoutRect(pixelSnappedIntRect(m_destRect))); setDestRect(LayoutRect(pixelSnappedIntRect(m_destRect)));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment