Skip to content

GitLab

T
tangled
Commit 977f8ce6 authored by Jan Scheffler's avatar Jan Scheffler Committed by Commit Bot
Browse files
Options

[Devtools] Reenable test for Cookie refactoring 

This cl reenables and fixes a test to refactor
how Cookies are handled in devtools frontend.

Cl with the actual changes: crrev.com/c/1959984
Cl disabling the test: crrev.com/c/1960350



Bug: chromium:1030258
Change-Id: I8f8bf9f4b0a6956dbbd019a5ced88fa2db066648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960279
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: default avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727991}
parent 4151e9e4
Hide whitespace changes
Inline Side-by-side
Showing with 39 additions and 134 deletions
third_party/blink/web_tests/TestExpectations
View file @ 977f8ce6
...@@ -6079,7 +6079,6 @@ crbug.com/993790 virtual/document-policy/external/wpt/document-policy/required-p ...@@ -6079,7 +6079,6 @@ crbug.com/993790 virtual/document-policy/external/wpt/document-policy/required-p
crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [ Pass Failure ] crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [ Pass Failure ]
crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ] crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ]
crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ] crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ]
crbug.com/1030258 http/tests/devtools/components/cookie-parser.js [ Pass Failure ]
crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ] crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ]
crbug.com/1019723 http/tests/devtools/network/waterfall-header-height-updates.js [ Pass Failure ] crbug.com/1019723 http/tests/devtools/network/waterfall-header-height-updates.js [ Pass Failure ]
......
third_party/blink/web_tests/http/tests/devtools/components/cookie-parser-expected.txt
View file @ 977f8ce6
Tests inspector cookie parser Tests inspector cookie parser
source: cookie=value source: cookie=value
name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12 name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12, priority: Medium
{
}
source: $version=1; a=b,c = d, e=f source: $version=1; a=b,c = d, e=f
name: a, value: b,c = d, e=f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 17 name: a, value: b,c = d, e=f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 17, priority: Medium
{
}
source: $version=1; a=b;c = d; e =f source: $version=1; a=b;c = d; e =f
name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 4 name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 4, priority: Medium
{ name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 10, priority: Medium
} name: e, value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 4, priority: Medium
name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 10
{
}
name: e, value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 4
{
}
source: cooke1 = value1; another cookie = another value source: cooke1 = value1; another cookie = another value
name: cooke1, value: value1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 25 name: cooke1, value: value1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 25, priority: Medium
{ name: cookie, value: another value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 22, priority: Medium
}
name: cookie, value: another value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 22
{
}
source: cooke1 = value; $Path=/; $Domain=.example.com; source: cooke1 = value; $Path=/; $Domain=.example.com;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 46 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 46, priority: Medium
{
domain : ".example.com"
path : "/"
}
source: cooke1 = value; $Path=/; $Domain=.example.com ; Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com; source: cooke1 = value; $Path=/; $Domain=.example.com ; Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 48 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 48, priority: Medium
{ name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58, priority: Medium
domain : ".example.com"
path : "/"
}
name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58
{
domain : "foo.example.com"
path : "/foo"
}
source: cooke1 = value; $Path=/; $Domain=.example.com source: cooke1 = value; $Path=/; $Domain=.example.com
Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com; Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 46 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 46, priority: Medium
{ name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 59, priority: Medium
domain : ".example.com"
path : "/"
}
name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 59
{
domain : "foo.example.com"
path : "/foo"
}
source: $version =1; cooke1 = value; $Path=/; $Domain =.example.com; source: $version =1; cooke1 = value; $Path=/; $Domain =.example.com;
Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com; Cookie2 = value2; $Path = /foo; $DOMAIN = foo.example.com;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 53 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 53, priority: Medium
{ name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58, priority: Medium
domain : ".example.com"
path : "/"
}
name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58
{
domain : "foo.example.com"
path : "/foo"
}
source: cookie=value source: cookie=value
name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12 name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12, priority: Medium
{
}
source: a=b source: a=b
c=d c=d
f f
name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5 name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5, priority: Medium
{ name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5, priority: Medium
} name: , value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 1, priority: Medium
name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5
{
}
name: , value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 1
{
}
source: cooke1 = value; Path=/; Domain=.example.com; source: cooke1 = value; Path=/; Domain=.example.com;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 44 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 44, priority: Medium
{
domain : ".example.com"
path : "/"
}
source: cooke1 = value; Path=/; Domain= .example.com source: cooke1 = value; Path=/; Domain= .example.com
Cookie2 = value2; Path = /foo; Domain = foo.example.com Cookie2 = value2; Path = /foo; Domain = foo.example.com
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 47 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 47, priority: Medium
{ name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 55, priority: Medium
domain : ".example.com"
path : "/"
}
name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 55
{
domain : "foo.example.com"
path : "/foo"
}
source: cooke1 = value; expires = Mon, Oct 18 2010 17:00 GMT+0000; Domain =.example.com source: cooke1 = value; expires = Mon, Oct 18 2010 17:00 GMT+0000; Domain =.example.com
Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard; Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: false, path: undefined, domain: .example.com, port: undefined, expires: 1287421200000, size: 82 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: false, path: undefined, domain: .example.com, port: undefined, expires: 1287421200000, size: 82, priority: Medium
{ name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83, priority: Medium
domain : ".example.com"
expires : "Mon, Oct 18 2010 17:00 GMT+0000"
}
name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83
{
discard : undefined
domain : "foo.example.com"
httponly : undefined
path : "/foo"
secure : undefined
}
source: cooke1 = value; max-age= 1440; Domain =.example.com source: cooke1 = value; max-age= 1440; Domain =.example.com
Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard; Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard;
name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: false, path: undefined, domain: .example.com, port: undefined, expires: 1287422640000, size: 55 name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: false, path: undefined, domain: .example.com, port: undefined, expires: 1287422640000, size: 55, priority: Medium
{ name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83, priority: Medium
domain : ".example.com"
max-age : "1440"
}
name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83
{
discard : undefined
domain : "foo.example.com"
httponly : undefined
path : "/foo"
secure : undefined
}
source: cooke1 = value; HttpOnly; Secure; SameSite=Lax; source: cooke1 = value; HttpOnly; Secure; SameSite=Lax;
name: cooke1, value: value, httpOnly: true, sameSite: Lax, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 47 name: cooke1, value: value, httpOnly: true, sameSite: Lax, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 47, priority: Medium
{
httponly : undefined
samesite : "Lax"
secure : undefined
}
source: cooke1 = value; HttpOnly; Secure; SameSite=Secure; source: cooke1 = value; HttpOnly; Secure; SameSite=Secure;
name: cooke1, value: value, httpOnly: true, sameSite: Secure, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 50 name: cooke1, value: value, httpOnly: true, sameSite: Secure, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 50, priority: Medium
{
httponly : undefined
samesite : "Secure"
secure : undefined
}
source: cooke1; Path=/; Domain=.example.com; source: cooke1; Path=/; Domain=.example.com;
name: , value: cooke1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 36 name: , value: cooke1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 36, priority: Medium
{
domain : ".example.com"
path : "/"
}
source: cooke1=; Path=/; Domain=.example.com; source: cooke1=; Path=/; Domain=.example.com;
name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 37 name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 37, priority: Medium
{ source: cooke1=; Path=/; Domain=.example.com; Priority=High
domain : ".example.com" name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 51, priority: High
path : "/" source: cooke1=; Path=/; Domain=.example.com; Priority=Low
} name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 50, priority: Low
source: cooke1=; Path=/; Domain=.example.com; Priority=Medium
name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 53, priority: Medium
third_party/blink/web_tests/http/tests/devtools/components/cookie-parser.js
View file @ 977f8ce6
...@@ -13,10 +13,9 @@ ...@@ -13,10 +13,9 @@
var output = 'name: ' + cookie.name() + ', value: ' + cookie.value() + ', httpOnly: ' + cookie.httpOnly() + var output = 'name: ' + cookie.name() + ', value: ' + cookie.value() + ', httpOnly: ' + cookie.httpOnly() +
', sameSite: ' + cookie.sameSite() + ', secure: ' + cookie.secure() + ', session: ' + cookie.session() + ', sameSite: ' + cookie.sameSite() + ', secure: ' + cookie.secure() + ', session: ' + cookie.session() +
', path: ' + cookie.path() + ', domain: ' + cookie.domain() + ', port: ' + cookie.port() + ', path: ' + cookie.path() + ', domain: ' + cookie.domain() + ', port: ' + cookie.port() +
', expires: ' + (expires ? expires.getTime() : 'n/a') + ', size: ' + cookie.size(); ', expires: ' + (expires ? expires.getTime() : 'n/a') + ', size: ' + cookie.size() + ', priority: ' + cookie.priority();
TestRunner.addResult(output); TestRunner.addResult(output);
TestRunner.addObject(cookie.attributes());
}; };
TestRunner.dumpCookies = function(cookies) { TestRunner.dumpCookies = function(cookies) {
...@@ -61,5 +60,8 @@ ...@@ -61,5 +60,8 @@
TestRunner.parseAndDumpSetCookie('cooke1 = value; HttpOnly; Secure; SameSite=Secure;'); TestRunner.parseAndDumpSetCookie('cooke1 = value; HttpOnly; Secure; SameSite=Secure;');
TestRunner.parseAndDumpSetCookie('cooke1; Path=/; Domain=.example.com;'); TestRunner.parseAndDumpSetCookie('cooke1; Path=/; Domain=.example.com;');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com;'); TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com;');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=High');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=Low');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=Medium');
TestRunner.completeTest(); TestRunner.completeTest();
})(); })();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment