Revert "Refactor Reader Mode's JavaScript tests to use Mocha."
This reverts commit 7de90169. Reason for revert: Suspicious to have broken DomDistillerViewerSourceBrowserTest.UISetsPrefs in browser_tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37476 Original change's description: > Refactor Reader Mode's JavaScript tests to use Mocha. > > The tests did not previously use an established test framework, making > tasks like executing certain code before or after every test and testing > asynchronous code more difficult. It should also be easier for > developers familiar with JavaScript testing in general and WebUI testing > in particular to read and write JavaScript tests for DOM Distiller and > Reader Mode. > > Follow-up work includes replacing the custom assert methods with Chai, > as well as writing more tests to cover existing functionality. > > Bug: 1027612 > Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Cr-Commit-Position: refs/heads/master@{#762551} TBR=wychen@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027612 Change-Id: I78b6b82e98c8f47951ab88e2056595de878f1ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166219Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762720}
Showing
This diff is collapsed.
Please register or sign in to comment