Commit 97f457fa authored by Juan Antonio Navarro Perez's avatar Juan Antonio Navarro Perez Committed by Commit Bot

[tools/perf] Increase timeout for TabStackTraceTest.testValidDump

To verify whether this fixes recent flakiness on Windows. Also re-enable
on Android.

TBR=crouleau@chromium.org

Bug: 971998
Change-Id: I5ad768b722524d518bcc85c826923eb4317c805e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941312Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720219}
parent 215f98e2
......@@ -15,11 +15,10 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
# Stack traces do not currently work on 10.6, but they are also being
# disabled shortly so just disable it for now.
# All platforms except chromeos should at least have a valid minidump.
# Disabled on Android, flaky: crbug.com/971998.
@decorators.Disabled('snowleopard', 'chromeos', 'android')
@decorators.Disabled('snowleopard', 'chromeos')
def testValidDump(self):
with self.assertRaises(exceptions.DevtoolsTargetCrashException) as c:
self._tab.Navigate('chrome://crash', timeout=5)
self._tab.Navigate('chrome://crash', timeout=10)
self.assertTrue(c.exception.is_valid_dump)
# Stack traces aren't working on Android yet.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment