Commit 98d72c40 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Disable remaining GUID-related bookmarks integration tests

The tests are flaky across multiple buiders. While the underlying issues
are investigated, let's disable them all.

TBR=mmoskvitin@chromium.org

Bug: 1012222,1012223,1009372
Change-Id: I0375dc684547d3fd927521f25898bd26514f4723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883647
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709855}
parent 1095a0b3
...@@ -788,7 +788,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, ...@@ -788,7 +788,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
/*REMOTE_INITIAL_UPDATE=*/5)); /*REMOTE_INITIAL_UPDATE=*/5));
} }
// TODO(crbug.com/1012222): re-enable this test on all builders once flakiness // TODO(crbug.com/1014086): re-enable this test on all builders once flakiness
// is addressed. // is addressed.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DISABLED_ApplyRemoteCreationWithValidGUID) { DISABLED_ApplyRemoteCreationWithValidGUID) {
...@@ -818,8 +818,10 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, ...@@ -818,8 +818,10 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->guid()); GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->guid());
} }
// TODO(crbug.com/1014086): re-enable this test on all builders once flakiness
// is addressed.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ApplyRemoteCreationWithoutValidGUID) { DISABLED_ApplyRemoteCreationWithoutValidGUID) {
// Start syncing. // Start syncing.
DisableVerifier(); DisableVerifier();
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
...@@ -852,15 +854,10 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, ...@@ -852,15 +854,10 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->guid()); GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->guid());
} }
#if defined(THREAD_SANITIZER) || defined(ADDRESS_SANITIZER) // TODO(crbug.com/1014086): re-enable this test on all builders once flakiness
#define MAYBE_ApplyRemoteCreationWithoutValidGUIDOrOCII \ // is addressed.
DISABLED_ApplyRemoteCreationWithoutValidGUIDOrOCII
#else
#define MAYBE_ApplyRemoteCreationWithoutValidGUIDOrOCII \
ApplyRemoteCreationWithoutValidGUIDOrOCII
#endif
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
MAYBE_ApplyRemoteCreationWithoutValidGUIDOrOCII) { DISABLED_ApplyRemoteCreationWithoutValidGUIDOrOCII) {
// Start syncing. // Start syncing.
DisableVerifier(); DisableVerifier();
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
...@@ -977,7 +974,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, ...@@ -977,7 +974,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
originator_client_item_id)); originator_client_item_id));
} }
// TODO(crbug.com/1012223): re-enable this test on all builders once flakiness // TODO(crbug.com/1014086): re-enable this test on all builders once flakiness
// is addressed. // is addressed.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DISABLED_ApplyRemoteUpdateWithValidGUID) { DISABLED_ApplyRemoteUpdateWithValidGUID) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment