Commit 992e0f97 authored by kkimlabs's avatar kkimlabs Committed by Commit bot

Revert of [Android] Temporarily suppress RTL start&end check error. (patchset...

Revert of [Android] Temporarily suppress RTL start&end check error. (patchset #1 id:1 of https://codereview.chromium.org/445753002/)

Reason for revert:
Android SDK fixed the issue, so we can convert back from warning to error.

Original issue's description:
> [Android] Temporarily suppress RTL start&end check error.
>
> The newest Android SDK had start&end attributes in non -v17 resources.
> Temporarily change the checking script from error to warning so that
> people can continue to work before it is fixed. This should be
> reverted once the issue is addressed
>
> BUG=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287711

TBR=newt@chromium.org,tedchoc@chromium.org,dfalcantara@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/555253004

Cr-Commit-Position: refs/heads/master@{#294038}
parent d0b993bb
...@@ -226,7 +226,7 @@ def VerifyV14ResourcesInDir(input_dir, resource_type): ...@@ -226,7 +226,7 @@ def VerifyV14ResourcesInDir(input_dir, resource_type):
don't use attributes that cause crashes on certain devices. Print an error if don't use attributes that cause crashes on certain devices. Print an error if
they have.""" they have."""
for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'): for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'):
warning_message = ('warning : ' + input_filename + ' has an RTL attribute, ' exception_message = ('error : ' + input_filename + ' has an RTL attribute, '
'i.e., attribute that has "start" or "end" in its name.' 'i.e., attribute that has "start" or "end" in its name.'
' Pre-v17 resources should not include it because it ' ' Pre-v17 resources should not include it because it '
'can cause crashes on certain devices. Please refer to ' 'can cause crashes on certain devices. Please refer to '
...@@ -234,10 +234,10 @@ def VerifyV14ResourcesInDir(input_dir, resource_type): ...@@ -234,10 +234,10 @@ def VerifyV14ResourcesInDir(input_dir, resource_type):
dom = minidom.parse(input_filename) dom = minidom.parse(input_filename)
if resource_type in ('layout', 'xml'): if resource_type in ('layout', 'xml'):
if GenerateV14LayoutResourceDom(dom, input_filename, False): if GenerateV14LayoutResourceDom(dom, input_filename, False):
print warning_message raise Exception(exception_message)
elif resource_type == 'values': elif resource_type == 'values':
if GenerateV14StyleResourceDom(dom, input_filename, False): if GenerateV14StyleResourceDom(dom, input_filename, False):
print warning_message raise Exception(exception_message)
def AssertNoDeprecatedAttributesInDir(input_dir, resource_type): def AssertNoDeprecatedAttributesInDir(input_dir, resource_type):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment