Commit 99d693bc authored by Henrik Boström's avatar Henrik Boström Committed by Chromium LUCI CQ

Disable WebRTC browser tests on Android that prevent rolling.

These tests fail before running due to https://crbug.com/1166107.
Running the tests on other platforms should be sufficient test coverage
until we figure out what the problem is.

TBR=guidou@chromium.org

Bug: chromium:1166107
Change-Id: I49aeac8d2a43290eb3a23fd4aeb2f00f5c4379bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629308Reviewed-by: default avatarMirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843491}
parent fb8e0241
...@@ -25,11 +25,18 @@ const char kVideoConstraints[] = "video:true"; ...@@ -25,11 +25,18 @@ const char kVideoConstraints[] = "video:true";
namespace content { namespace content {
#if defined(OS_ANDROID)
// Test fails on WebRTC Android FYI: https://crbug.com/1166107
#define MAYBE_WebRtcAudioBrowserTest DISABLED_WebRtcAudioBrowserTest
#else
#define MAYBE_WebRtcAudioBrowserTest WebRtcAudioBrowserTest
#endif
// This class tests the scenario when permission to access mic or camera is // This class tests the scenario when permission to access mic or camera is
// granted. // granted.
class WebRtcAudioBrowserTest : public WebRtcContentBrowserTestBase { class MAYBE_WebRtcAudioBrowserTest : public WebRtcContentBrowserTestBase {
public: public:
~WebRtcAudioBrowserTest() override {} ~MAYBE_WebRtcAudioBrowserTest() override {}
void SetUpCommandLine(base::CommandLine* command_line) override { void SetUpCommandLine(base::CommandLine* command_line) override {
WebRtcContentBrowserTestBase::SetUpCommandLine(command_line); WebRtcContentBrowserTestBase::SetUpCommandLine(command_line);
...@@ -118,7 +125,7 @@ class WebRtcAudioBrowserTest : public WebRtcContentBrowserTestBase { ...@@ -118,7 +125,7 @@ class WebRtcAudioBrowserTest : public WebRtcContentBrowserTestBase {
#endif // defined(OS_MAC) #endif // defined(OS_MAC)
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_CanMakeVideoCallAndThenRenegotiateToAudio) { MAYBE_CanMakeVideoCallAndThenRenegotiateToAudio) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -128,7 +135,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -128,7 +135,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
audio_only_constraints + ");"); audio_only_constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EstablishAudioVideoCallAndEnsureAudioIsPlaying) { MAYBE_EstablishAudioVideoCallAndEnsureAudioIsPlaying) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -136,7 +143,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -136,7 +143,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
constraints + ");"); constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EstablishAudioOnlyCallAndEnsureAudioIsPlaying) { MAYBE_EstablishAudioOnlyCallAndEnsureAudioIsPlaying) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -144,7 +151,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -144,7 +151,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
constraints + ");"); constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EstablishIsac16KCallAndEnsureAudioIsPlaying) { MAYBE_EstablishIsac16KCallAndEnsureAudioIsPlaying) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -152,7 +159,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -152,7 +159,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
"callWithIsac16KAndEnsureAudioIsPlaying(" + constraints + ");"); "callWithIsac16KAndEnsureAudioIsPlaying(" + constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
EstablishAudioVideoCallAndVerifyRemoteMutingWorks) { EstablishAudioVideoCallAndVerifyRemoteMutingWorks) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -160,7 +167,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -160,7 +167,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
"callAndEnsureRemoteAudioTrackMutingWorks(" + constraints + ");"); "callAndEnsureRemoteAudioTrackMutingWorks(" + constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
EstablishAudioVideoCallAndVerifyLocalMutingWorks) { EstablishAudioVideoCallAndVerifyLocalMutingWorks) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -168,7 +175,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -168,7 +175,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
"callAndEnsureLocalAudioTrackMutingWorks(" + constraints + ");"); "callAndEnsureLocalAudioTrackMutingWorks(" + constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EnsureLocalVideoMuteDoesntMuteAudio) { MAYBE_EnsureLocalVideoMuteDoesntMuteAudio) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -176,7 +183,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -176,7 +183,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
"callAndEnsureLocalVideoMutingDoesntMuteAudio(" + constraints + ");"); "callAndEnsureLocalVideoMutingDoesntMuteAudio(" + constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EnsureRemoteVideoMuteDoesntMuteAudio) { MAYBE_EnsureRemoteVideoMuteDoesntMuteAudio) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -184,7 +191,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -184,7 +191,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
"callAndEnsureRemoteVideoMutingDoesntMuteAudio(" + constraints + ");"); "callAndEnsureRemoteVideoMutingDoesntMuteAudio(" + constraints + ");");
} }
IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioBrowserTest,
MAYBE_EstablishAudioVideoCallAndVerifyUnmutingWorks) { MAYBE_EstablishAudioVideoCallAndVerifyUnmutingWorks) {
std::string constraints = std::string constraints =
BuildConstraints(kAudioConstraints, kVideoConstraints); BuildConstraints(kAudioConstraints, kVideoConstraints);
...@@ -195,7 +202,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest, ...@@ -195,7 +202,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioBrowserTest,
// TODO(crbug.com/988432): This test is a temporary replacement for: // TODO(crbug.com/988432): This test is a temporary replacement for:
// external/wpt/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html // external/wpt/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
WebRtcAudioBrowserTest, MAYBE_WebRtcAudioBrowserTest,
MAYBE_EstablishAudioOnlyCallAndVerifyGetSynchronizationSourcesWorks) { MAYBE_EstablishAudioOnlyCallAndVerifyGetSynchronizationSourcesWorks) {
MakeAudioDetectingPeerConnectionCall( MakeAudioDetectingPeerConnectionCall(
"testEstablishAudioOnlyCallAndVerifyGetSynchronizationSourcesWorks();"); "testEstablishAudioOnlyCallAndVerifyGetSynchronizationSourcesWorks();");
......
...@@ -23,8 +23,11 @@ ...@@ -23,8 +23,11 @@
namespace content { namespace content {
#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER) #if defined(OS_ANDROID)
// Renderer crashes under Android ASAN: https://crbug.com/408496. // Renderer crashes under Android ASAN (ADDRESS_SANITIZER):
// https://crbug.com/408496.
// Test fails on WebRTC Android FYI (even without ASAN):
// https://crbug.com/1166107
#define MAYBE_WebRtcBrowserTest DISABLED_WebRtcBrowserTest #define MAYBE_WebRtcBrowserTest DISABLED_WebRtcBrowserTest
#else #else
#define MAYBE_WebRtcBrowserTest WebRtcBrowserTest #define MAYBE_WebRtcBrowserTest WebRtcBrowserTest
......
...@@ -20,8 +20,11 @@ ...@@ -20,8 +20,11 @@
namespace content { namespace content {
#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER) #if defined(OS_ANDROID)
// Renderer crashes under Android ASAN: https://crbug.com/408496. // Renderer crashes under Android ASAN (ADDRESS_SANITIZER):
// https://crbug.com/408496.
// Test fails on WebRTC Android FYI (even without ASAN):
// https://crbug.com/1166107
#define MAYBE_WebRtcDataBrowserTest DISABLED_WebRtcDataBrowserTest #define MAYBE_WebRtcDataBrowserTest DISABLED_WebRtcDataBrowserTest
#else #else
#define MAYBE_WebRtcDataBrowserTest WebRtcDataBrowserTest #define MAYBE_WebRtcDataBrowserTest WebRtcDataBrowserTest
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment