Commit 99eb4b03 authored by Helen Li's avatar Helen Li Committed by Commit Bot

Add a note to network::ProxyResolvingClientSocket on quic proxy

This CL adds a note to ProxyResolvingClientSocket on why QUIC proxy
isn't yet supported and links to crbug.

Bug: 876885
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5d07064e252e8bdd9b28281488d88613fa102bd4
Reviewed-on: https://chromium-review.googlesource.com/1185746Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585837}
parent 6a1ea3ac
...@@ -264,8 +264,9 @@ int ProxyResolvingClientSocket::DoProxyResolveComplete(int result) { ...@@ -264,8 +264,9 @@ int ProxyResolvingClientSocket::DoProxyResolveComplete(int result) {
proxy_resolve_request_ = nullptr; proxy_resolve_request_ = nullptr;
if (result == net::OK) { if (result == net::OK) {
// Removes unsupported proxies from the list. Currently, this removes // Removes unsupported proxies from the list. Currently, this removes
// just the SCHEME_QUIC proxy, which doesn't yet support tunneling. // just the SCHEME_QUIC proxy.
// TODO(xunjieli): Allow QUIC proxy once it supports tunneling. // TODO(crbug.com/876885): Allow QUIC proxy once net::QuicProxyClientSocket
// supports ReadIfReady() and CancelReadIfReady().
proxy_info_.RemoveProxiesWithoutScheme( proxy_info_.RemoveProxiesWithoutScheme(
net::ProxyServer::SCHEME_DIRECT | net::ProxyServer::SCHEME_HTTP | net::ProxyServer::SCHEME_DIRECT | net::ProxyServer::SCHEME_HTTP |
net::ProxyServer::SCHEME_HTTPS | net::ProxyServer::SCHEME_SOCKS4 | net::ProxyServer::SCHEME_HTTPS | net::ProxyServer::SCHEME_SOCKS4 |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment