Commit 99ed2aab authored by gunsch's avatar gunsch Committed by Commit bot

Reverts Chromecast using external V8 snapshot files.

This currently breaks at runtime both cast_shell and cast_shell_apk
and I wasn't able to find an easy fix. I'd like to unblock our other development in the meantime.

Half-revert of https://codereview.chromium.org/1019123002/

TBR=jochen@chromium.org
R=rmcilroy@chromium.org,lcwu@chromium.org
BUG=421063

Review URL: https://codereview.chromium.org/1073583004

Cr-Commit-Position: refs/heads/master@{#324376}
parent d0856baa
...@@ -1022,8 +1022,8 @@ ...@@ -1022,8 +1022,8 @@
'optimize_jni_generation%': 0, 'optimize_jni_generation%': 0,
}], }],
# TODO(rmcilroy): Remove ios check. http://crbug.com/421063. # TODO(rmcilroy): Remove ios/chromecast checks. http://crbug.com/421063.
['OS!="ios"', { ['OS!="ios" and chromecast==0', {
'v8_use_external_startup_data%': 1, 'v8_use_external_startup_data%': 1,
}, { }, {
'v8_use_external_startup_data%': 0, 'v8_use_external_startup_data%': 0,
......
...@@ -354,14 +354,11 @@ ...@@ -354,14 +354,11 @@
'type': 'none', 'type': 'none',
'dependencies': [ 'dependencies': [
'../third_party/icu/icu.gyp:icudata', '../third_party/icu/icu.gyp:icudata',
'../v8/tools/gyp/v8.gyp:v8_external_snapshot',
], ],
'copies': [{ 'copies': [{
'destination': '<(PRODUCT_DIR)/assets', 'destination': '<(PRODUCT_DIR)/assets',
'files': [ 'files': [
'<(PRODUCT_DIR)/icudtl.dat', '<(PRODUCT_DIR)/icudtl.dat',
'<(PRODUCT_DIR)/natives_blob.bin',
'<(PRODUCT_DIR)/snapshot_blob.bin',
], ],
}], }],
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment