Commit 9a3203bd authored by Patrik Höglund's avatar Patrik Höglund Committed by Commit Bot

Make audio quality test upload if PESQ score is sufficiently bad.

R=guidou

Bug: 767857
Change-Id: I1a3aa68c3a6996c17bc9d0b96595736e4fb453ab
Reviewed-on: https://chromium-review.googlesource.com/741598
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512860}
parent 096f638e
...@@ -411,9 +411,16 @@ class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase { ...@@ -411,9 +411,16 @@ class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase {
"score", true); "score", true);
} }
if (CanParseAsFloat(mos_lqo) && atof(mos_lqo.c_str()) < 3.0f) {
// If we keep the recordings, it's possible for the WebRTC bot recipes to
// upload them and make them available on the build.
printf("Suspiciously low MOS-LQO score: keeping recordings...\n");
return;
} else {
DeleteFileUnlessTestFailed(trimmed_reference, false); DeleteFileUnlessTestFailed(trimmed_reference, false);
DeleteFileUnlessTestFailed(trimmed_recording, false); DeleteFileUnlessTestFailed(trimmed_recording, false);
} }
}
bool CanParseAsFloat(const std::string& value) { bool CanParseAsFloat(const std::string& value) {
return atof(value.c_str()) != 0 || value == "0"; return atof(value.c_str()) != 0 || value == "0";
...@@ -464,7 +471,7 @@ class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase { ...@@ -464,7 +471,7 @@ class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase {
if (anchor_pos == std::string::npos) { if (anchor_pos == std::string::npos) {
LOG(ERROR) LOG(ERROR)
<< "PESQ was not able to compute a score; we probably recorded " << "PESQ was not able to compute a score; we probably recorded "
<< "only silence. Please check the output/input volume levels."; << "only silence.";
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment