Commit 9a7c6714 authored by Lu Chen's avatar Lu Chen Committed by Commit Bot

Add tbansal@ as owner to histograms AnchorElementMetrics.*.

Also a typo is fixed.

Bug: 850624
Change-Id: I48e73389406327d373ce3c4e269a141314bf3bc7
Reviewed-on: https://chromium-review.googlesource.com/1152178Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578693}
parent c1d0a59d
...@@ -602,20 +602,22 @@ uploading your change for review. ...@@ -602,20 +602,22 @@ uploading your change for review.
AnchorElementMetrics.Clicked.HrefEngagementScore2. AnchorElementMetrics.Clicked.HrefEngagementScore2.
</obsolete> </obsolete>
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The target link (href) engagement score of an anchor element. The score is The target link (href) engagement score of an anchor element. The score is
retrived from the site engagement service. Currently all scores reported are retrieved from the site engagement service. Currently all scores reported
set to 0. This will soon change. This histogram is recorded when the anchor are set to 0. This will soon change. This histogram is recorded when the
element is clicked. anchor element is clicked.
</summary> </summary>
</histogram> </histogram>
<histogram name="AnchorElementMetrics.Clicked.HrefEngagementScore2" <histogram name="AnchorElementMetrics.Clicked.HrefEngagementScore2"
units="score"> units="score">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The site engagement score of the target link (href) of an anchor element. The site engagement score of the target link (href) of an anchor element.
The score is retrived from the site engagement service. This histogram is The score is retrieved from the site engagement service. This histogram is
recorded when the anchor element is clicked. recorded when the anchor element is clicked.
</summary> </summary>
</histogram> </histogram>
...@@ -623,15 +625,17 @@ uploading your change for review. ...@@ -623,15 +625,17 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.Clicked.HrefEngagementScorePositive" <histogram name="AnchorElementMetrics.Clicked.HrefEngagementScorePositive"
units="score"> units="score">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The site engagement score of the target link (href) of an anchor element. The site engagement score of the target link (href) of an anchor element.
The score is retrived from the site engagement service. This histogram is The score is retrieved from the site engagement service. This histogram is
recorded when the anchor element is clicked, and the score is larger than 0. recorded when the anchor element is clicked, and the score is larger than 0.
</summary> </summary>
</histogram> </histogram>
<histogram name="AnchorElementMetrics.ContainsImage" enum="Boolean"> <histogram name="AnchorElementMetrics.ContainsImage" enum="Boolean">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
True if the anchor element contains an image element, false if it is not. True if the anchor element contains an image element, false if it is not.
</summary> </summary>
...@@ -639,6 +643,7 @@ uploading your change for review. ...@@ -639,6 +643,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.IsInIFrame" enum="Boolean"> <histogram name="AnchorElementMetrics.IsInIFrame" enum="Boolean">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
True if the anchor element is within an iframe, false if it is not. True if the anchor element is within an iframe, false if it is not.
</summary> </summary>
...@@ -646,6 +651,7 @@ uploading your change for review. ...@@ -646,6 +651,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.IsSameHost" enum="Boolean"> <histogram name="AnchorElementMetrics.IsSameHost" enum="Boolean">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
True if the target link of the anchor element has the same host as the root True if the target link of the anchor element has the same host as the root
document. document.
...@@ -654,6 +660,7 @@ uploading your change for review. ...@@ -654,6 +660,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.IsUrlIncrementedByOne" enum="Boolean"> <histogram name="AnchorElementMetrics.IsUrlIncrementedByOne" enum="Boolean">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
True if the target URL of the anchor element and the URL of the root True if the target URL of the anchor element and the URL of the root
document only differ by one number, and the number in the target URL equals document only differ by one number, and the number in the target URL equals
...@@ -663,6 +670,7 @@ uploading your change for review. ...@@ -663,6 +670,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioArea" units="%"> <histogram name="AnchorElementMetrics.RatioArea" units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the clickable region area of an anchor element, The ratio times 100 between the clickable region area of an anchor element,
and the viewport area. and the viewport area.
...@@ -672,6 +680,7 @@ uploading your change for review. ...@@ -672,6 +680,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioDistanceCenterToVisibleTop" <histogram name="AnchorElementMetrics.RatioDistanceCenterToVisibleTop"
units="%"> units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the distance from the center of the clickable The ratio times 100 between the distance from the center of the clickable
region of an anchor element to the top edge of the visible region, and the region of an anchor element to the top edge of the visible region, and the
...@@ -681,6 +690,7 @@ uploading your change for review. ...@@ -681,6 +690,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioDistanceRootBottom" units="%"> <histogram name="AnchorElementMetrics.RatioDistanceRootBottom" units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the distance from the bottom of the clickable The ratio times 100 between the distance from the bottom of the clickable
region of an anchor element to the bottom edge of the root frame, and the region of an anchor element to the bottom edge of the root frame, and the
...@@ -690,6 +700,7 @@ uploading your change for review. ...@@ -690,6 +700,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioDistanceRootTop" units="%"> <histogram name="AnchorElementMetrics.RatioDistanceRootTop" units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the distance from the top of the clickable The ratio times 100 between the distance from the top of the clickable
region of an anchor element to the top edge of the root frame, and the region of an anchor element to the top edge of the root frame, and the
...@@ -699,6 +710,7 @@ uploading your change for review. ...@@ -699,6 +710,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioDistanceTopToVisibleTop" units="%"> <histogram name="AnchorElementMetrics.RatioDistanceTopToVisibleTop" units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the distance from the top of the clickable The ratio times 100 between the distance from the top of the clickable
region of an anchor element to the top edge of the visible region, and the region of an anchor element to the top edge of the visible region, and the
...@@ -708,6 +720,7 @@ uploading your change for review. ...@@ -708,6 +720,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.RatioVisibleArea" units="%"> <histogram name="AnchorElementMetrics.RatioVisibleArea" units="%">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The ratio times 100 between the visible clickable region area of an anchor The ratio times 100 between the visible clickable region area of an anchor
element, and the viewport area. element, and the viewport area.
...@@ -717,6 +730,7 @@ uploading your change for review. ...@@ -717,6 +730,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.Visible.HighestNavigationScore" <histogram name="AnchorElementMetrics.Visible.HighestNavigationScore"
units="score"> units="score">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The highest navigation score of the anchor elements sent to the browser The highest navigation score of the anchor elements sent to the browser
process on a page load. This histogram is recorded when the webpage is process on a page load. This histogram is recorded when the webpage is
...@@ -727,6 +741,7 @@ uploading your change for review. ...@@ -727,6 +741,7 @@ uploading your change for review.
<histogram name="AnchorElementMetrics.Visible.NumberOfAnchorElements" <histogram name="AnchorElementMetrics.Visible.NumberOfAnchorElements"
units="count"> units="count">
<owner>chelu@chromium.org</owner> <owner>chelu@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
<summary> <summary>
The number of anchor element metrics sent to the browser process on a page The number of anchor element metrics sent to the browser process on a page
load. This histogram is recorded when the webpage is loaded. load. This histogram is recorded when the webpage is loaded.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment