Commit 9a8e3d71 authored by morrita's avatar morrita Committed by Commit bot

Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute()

This is an equivalent of DCHECK() in IDMap.
According to crbug.com/381990, this can occasionally crash.
I'd like to enable this to collect more data if it still crashes.
If you see this CHECK() being hit in the wild,
please revert this change and let me know.

BUG=381990, 415059
R=nasko@chromium.org, amineer@chromium.org

Review URL: https://codereview.chromium.org/647623003

Cr-Commit-Position: refs/heads/master@{#299146}
parent be3c72f8
......@@ -920,6 +920,9 @@ ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {
void RenderProcessHostImpl::AddRoute(
int32 routing_id,
IPC::Listener* listener) {
// We already have DCHECK() in IDMap. This is for chasing
// crbug.com/415059 and can be removed after fixing it.
CHECK(!listeners_.Lookup(routing_id));
listeners_.AddWithID(listener, routing_id);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment