Commit 9b490132 authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Remove updatedCupsPrintersUiEnabled

- This is the first part of removing legacy printer settings code.
- Future CL's will iteratively remove each piece of the feature flag and
  the code gated by it.

Bug: 1005905
Test: Ran browsertests + end to end manual
Change-Id: I4e4680e7eb2dcd08d03f69538fc09331b3f39a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935152Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722523}
parent a3effa45
...@@ -66,7 +66,7 @@ Polymer({ ...@@ -66,7 +66,7 @@ Polymer({
enableUpdatedUi_: { enableUpdatedUi_: {
type: Boolean, type: Boolean,
value: function() { value: function() {
return loadTimeData.getBoolean('updatedCupsPrintersUiEnabled'); return true;
}, },
}, },
......
...@@ -2527,10 +2527,6 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) { ...@@ -2527,10 +2527,6 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) {
html_source->AddString( html_source->AddString(
"printingCUPSPrintPpdLearnMoreUrl", "printingCUPSPrintPpdLearnMoreUrl",
GetHelpUrlWithBoard(chrome::kCupsPrintPPDLearnMoreURL)); GetHelpUrlWithBoard(chrome::kCupsPrintPPDLearnMoreURL));
html_source->AddBoolean(
"updatedCupsPrintersUiEnabled",
base::FeatureList::IsEnabled(features::kCupsPrintersUiOverhaul));
#endif #endif
} }
......
...@@ -116,6 +116,8 @@ suite('CupsAddPrinterDialogTests', function() { ...@@ -116,6 +116,8 @@ suite('CupsAddPrinterDialogTests', function() {
PolymerTest.clearBody(); PolymerTest.clearBody();
page = document.createElement('settings-cups-printers'); page = document.createElement('settings-cups-printers');
// TODO(jimmyxgong): Remove this line when the feature flag is removed.
page.enableUpdatedUi_ = false;
document.body.appendChild(page); document.body.appendChild(page);
assertTrue(!!page); assertTrue(!!page);
dialog = page.$$('settings-cups-add-printer-dialog'); dialog = page.$$('settings-cups-add-printer-dialog');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment