Commit 9bca1ca4 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

[ios] Fix uses of ios::ChromeBrowserState in /ios/chrome/browser/sessions

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=rohitrao@chromium.org

Bug: 1042208
Change-Id: I0fef4370bdd2a9376af40bc40f93c6fef949b625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017325Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735276}
parent 0c5f6cb9
...@@ -7,15 +7,15 @@ ...@@ -7,15 +7,15 @@
#include "base/macros.h" #include "base/macros.h"
#include "components/sessions/core/tab_restore_service_client.h" #include "components/sessions/core/tab_restore_service_client.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
class ChromeBrowserState;
// IOSChromeTabRestoreServiceClient provides an implementation of // IOSChromeTabRestoreServiceClient provides an implementation of
// TabRestoreServiceClient that depends on ios/chrome/. // TabRestoreServiceClient that depends on ios/chrome/.
class IOSChromeTabRestoreServiceClient class IOSChromeTabRestoreServiceClient
: public sessions::TabRestoreServiceClient { : public sessions::TabRestoreServiceClient {
public: public:
explicit IOSChromeTabRestoreServiceClient( explicit IOSChromeTabRestoreServiceClient(ChromeBrowserState* browser_state);
ios::ChromeBrowserState* browser_state);
~IOSChromeTabRestoreServiceClient() override; ~IOSChromeTabRestoreServiceClient() override;
private: private:
...@@ -37,7 +37,7 @@ class IOSChromeTabRestoreServiceClient ...@@ -37,7 +37,7 @@ class IOSChromeTabRestoreServiceClient
void GetLastSession(sessions::GetLastSessionCallback callback, void GetLastSession(sessions::GetLastSessionCallback callback,
base::CancelableTaskTracker* tracker) override; base::CancelableTaskTracker* tracker) override;
ios::ChromeBrowserState* browser_state_; ChromeBrowserState* browser_state_;
DISALLOW_COPY_AND_ASSIGN(IOSChromeTabRestoreServiceClient); DISALLOW_COPY_AND_ASSIGN(IOSChromeTabRestoreServiceClient);
}; };
......
...@@ -27,12 +27,12 @@ ...@@ -27,12 +27,12 @@
namespace { namespace {
sessions::LiveTabContext* FindLiveTabContextWithCondition( sessions::LiveTabContext* FindLiveTabContextWithCondition(
base::RepeatingCallback<bool(TabModel*)> condition) { base::RepeatingCallback<bool(TabModel*)> condition) {
std::vector<ios::ChromeBrowserState*> browser_states = std::vector<ChromeBrowserState*> browser_states =
GetApplicationContext() GetApplicationContext()
->GetChromeBrowserStateManager() ->GetChromeBrowserStateManager()
->GetLoadedBrowserStates(); ->GetLoadedBrowserStates();
for (ios::ChromeBrowserState* browser_state : browser_states) { for (ChromeBrowserState* browser_state : browser_states) {
DCHECK(!browser_state->IsOffTheRecord()); DCHECK(!browser_state->IsOffTheRecord());
NSArray<TabModel*>* tab_models; NSArray<TabModel*>* tab_models;
...@@ -47,7 +47,7 @@ sessions::LiveTabContext* FindLiveTabContextWithCondition( ...@@ -47,7 +47,7 @@ sessions::LiveTabContext* FindLiveTabContextWithCondition(
if (!browser_state->HasOffTheRecordChromeBrowserState()) if (!browser_state->HasOffTheRecordChromeBrowserState())
continue; continue;
ios::ChromeBrowserState* otr_browser_state = ChromeBrowserState* otr_browser_state =
browser_state->GetOffTheRecordChromeBrowserState(); browser_state->GetOffTheRecordChromeBrowserState();
tab_models = tab_models =
...@@ -65,7 +65,7 @@ sessions::LiveTabContext* FindLiveTabContextWithCondition( ...@@ -65,7 +65,7 @@ sessions::LiveTabContext* FindLiveTabContextWithCondition(
} // namespace } // namespace
IOSChromeTabRestoreServiceClient::IOSChromeTabRestoreServiceClient( IOSChromeTabRestoreServiceClient::IOSChromeTabRestoreServiceClient(
ios::ChromeBrowserState* browser_state) ChromeBrowserState* browser_state)
: browser_state_(browser_state) {} : browser_state_(browser_state) {}
IOSChromeTabRestoreServiceClient::~IOSChromeTabRestoreServiceClient() {} IOSChromeTabRestoreServiceClient::~IOSChromeTabRestoreServiceClient() {}
......
...@@ -18,8 +18,8 @@ std::unique_ptr<KeyedService> BuildTabRestoreService( ...@@ -18,8 +18,8 @@ std::unique_ptr<KeyedService> BuildTabRestoreService(
web::BrowserState* context) { web::BrowserState* context) {
DCHECK(!context->IsOffTheRecord()); DCHECK(!context->IsOffTheRecord());
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state =
ios::ChromeBrowserState::FromBrowserState(context); ChromeBrowserState::FromBrowserState(context);
return std::make_unique<sessions::TabRestoreServiceImpl>( return std::make_unique<sessions::TabRestoreServiceImpl>(
base::WrapUnique(new IOSChromeTabRestoreServiceClient(browser_state)), base::WrapUnique(new IOSChromeTabRestoreServiceClient(browser_state)),
browser_state->GetPrefs(), nullptr); browser_state->GetPrefs(), nullptr);
...@@ -30,7 +30,7 @@ std::unique_ptr<KeyedService> BuildTabRestoreService( ...@@ -30,7 +30,7 @@ std::unique_ptr<KeyedService> BuildTabRestoreService(
// static // static
sessions::TabRestoreService* sessions::TabRestoreService*
IOSChromeTabRestoreServiceFactory::GetForBrowserState( IOSChromeTabRestoreServiceFactory::GetForBrowserState(
ios::ChromeBrowserState* browser_state) { ChromeBrowserState* browser_state) {
return static_cast<sessions::TabRestoreService*>( return static_cast<sessions::TabRestoreService*>(
GetInstance()->GetServiceForBrowserState(browser_state, true)); GetInstance()->GetServiceForBrowserState(browser_state, true));
} }
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
#include "components/keyed_service/ios/browser_state_keyed_service_factory.h" #include "components/keyed_service/ios/browser_state_keyed_service_factory.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
class ChromeBrowserState;
namespace sessions { namespace sessions {
class TabRestoreService; class TabRestoreService;
...@@ -22,7 +23,7 @@ class IOSChromeTabRestoreServiceFactory ...@@ -22,7 +23,7 @@ class IOSChromeTabRestoreServiceFactory
: public BrowserStateKeyedServiceFactory { : public BrowserStateKeyedServiceFactory {
public: public:
static sessions::TabRestoreService* GetForBrowserState( static sessions::TabRestoreService* GetForBrowserState(
ios::ChromeBrowserState* browser_state); ChromeBrowserState* browser_state);
static IOSChromeTabRestoreServiceFactory* GetInstance(); static IOSChromeTabRestoreServiceFactory* GetInstance();
......
...@@ -11,9 +11,9 @@ ...@@ -11,9 +11,9 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/observer_list.h" #include "base/observer_list.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
#include "ios/chrome/browser/main/browser_user_data.h" #include "ios/chrome/browser/main/browser_user_data.h"
class ChromeBrowserState;
@class SessionWindowIOS; @class SessionWindowIOS;
@class SessionIOSFactory; @class SessionIOSFactory;
class SessionRestorationObserver; class SessionRestorationObserver;
...@@ -69,7 +69,7 @@ class SessionRestorationBrowserAgent ...@@ -69,7 +69,7 @@ class SessionRestorationBrowserAgent
base::ObserverList<SessionRestorationObserver, true> observers_; base::ObserverList<SessionRestorationObserver, true> observers_;
ios::ChromeBrowserState* browser_state_; ChromeBrowserState* browser_state_;
// Session Factory used to create session data for saving. // Session Factory used to create session data for saving.
SessionIOSFactory* session_ios_factory_; SessionIOSFactory* session_ios_factory_;
......
...@@ -9,7 +9,8 @@ ...@@ -9,7 +9,8 @@
#include <vector> #include <vector>
#include "base/callback.h" #include "base/callback.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
class ChromeBrowserState;
namespace sessions { namespace sessions {
class SerializedNavigationEntry; class SerializedNavigationEntry;
...@@ -25,7 +26,7 @@ namespace session_util { ...@@ -25,7 +26,7 @@ namespace session_util {
// Create a WebState initialized with |browser_state| and serialized navigation. // Create a WebState initialized with |browser_state| and serialized navigation.
// The returned WebState has web usage enabled. // The returned WebState has web usage enabled.
std::unique_ptr<web::WebState> CreateWebStateWithNavigationEntries( std::unique_ptr<web::WebState> CreateWebStateWithNavigationEntries(
ios::ChromeBrowserState* browser_state, ChromeBrowserState* browser_state,
int last_committed_item_index, int last_committed_item_index,
const std::vector<sessions::SerializedNavigationEntry>& navigations); const std::vector<sessions::SerializedNavigationEntry>& navigations);
......
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
namespace session_util { namespace session_util {
std::unique_ptr<web::WebState> CreateWebStateWithNavigationEntries( std::unique_ptr<web::WebState> CreateWebStateWithNavigationEntries(
ios::ChromeBrowserState* browser_state, ChromeBrowserState* browser_state,
int last_committed_item_index, int last_committed_item_index,
const std::vector<sessions::SerializedNavigationEntry>& navigations) { const std::vector<sessions::SerializedNavigationEntry>& navigations) {
DCHECK_GE(last_committed_item_index, 0); DCHECK_GE(last_committed_item_index, 0);
......
...@@ -13,8 +13,8 @@ ...@@ -13,8 +13,8 @@
#include "components/sessions/core/live_tab_context.h" #include "components/sessions/core/live_tab_context.h"
#include "components/tab_groups/tab_group_id.h" #include "components/tab_groups/tab_group_id.h"
#include "components/tab_groups/tab_group_visual_data.h" #include "components/tab_groups/tab_group_visual_data.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
class ChromeBrowserState;
class WebStateList; class WebStateList;
// Implementation of sessions::LiveTabContext which uses an instance // Implementation of sessions::LiveTabContext which uses an instance
...@@ -22,8 +22,7 @@ class WebStateList; ...@@ -22,8 +22,7 @@ class WebStateList;
class TabRestoreServiceDelegateImplIOS : public sessions::LiveTabContext, class TabRestoreServiceDelegateImplIOS : public sessions::LiveTabContext,
public KeyedService { public KeyedService {
public: public:
explicit TabRestoreServiceDelegateImplIOS( explicit TabRestoreServiceDelegateImplIOS(ChromeBrowserState* browser_state);
ios::ChromeBrowserState* browser_state);
~TabRestoreServiceDelegateImplIOS() override; ~TabRestoreServiceDelegateImplIOS() override;
// Overridden from KeyedService: // Overridden from KeyedService:
...@@ -74,7 +73,7 @@ class TabRestoreServiceDelegateImplIOS : public sessions::LiveTabContext, ...@@ -74,7 +73,7 @@ class TabRestoreServiceDelegateImplIOS : public sessions::LiveTabContext,
// Retrieves the current |WebStateList| corresponding to |browser_state_|; // Retrieves the current |WebStateList| corresponding to |browser_state_|;
WebStateList* GetWebStateList() const; WebStateList* GetWebStateList() const;
ios::ChromeBrowserState* browser_state_; // weak ChromeBrowserState* browser_state_; // weak
SessionID session_id_; SessionID session_id_;
DISALLOW_COPY_AND_ASSIGN(TabRestoreServiceDelegateImplIOS); DISALLOW_COPY_AND_ASSIGN(TabRestoreServiceDelegateImplIOS);
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
#endif #endif
TabRestoreServiceDelegateImplIOS::TabRestoreServiceDelegateImplIOS( TabRestoreServiceDelegateImplIOS::TabRestoreServiceDelegateImplIOS(
ios::ChromeBrowserState* browser_state) ChromeBrowserState* browser_state)
: browser_state_(browser_state), session_id_(SessionID::NewUnique()) {} : browser_state_(browser_state), session_id_(SessionID::NewUnique()) {}
TabRestoreServiceDelegateImplIOS::~TabRestoreServiceDelegateImplIOS() {} TabRestoreServiceDelegateImplIOS::~TabRestoreServiceDelegateImplIOS() {}
......
...@@ -10,15 +10,15 @@ ...@@ -10,15 +10,15 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
#include "components/keyed_service/ios/browser_state_keyed_service_factory.h" #include "components/keyed_service/ios/browser_state_keyed_service_factory.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state_forward.h"
class ChromeBrowserState;
class TabRestoreServiceDelegateImplIOS; class TabRestoreServiceDelegateImplIOS;
class TabRestoreServiceDelegateImplIOSFactory class TabRestoreServiceDelegateImplIOSFactory
: public BrowserStateKeyedServiceFactory { : public BrowserStateKeyedServiceFactory {
public: public:
static TabRestoreServiceDelegateImplIOS* GetForBrowserState( static TabRestoreServiceDelegateImplIOS* GetForBrowserState(
ios::ChromeBrowserState* browser_state); ChromeBrowserState* browser_state);
static TabRestoreServiceDelegateImplIOSFactory* GetInstance(); static TabRestoreServiceDelegateImplIOSFactory* GetInstance();
......
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
// static // static
TabRestoreServiceDelegateImplIOS* TabRestoreServiceDelegateImplIOS*
TabRestoreServiceDelegateImplIOSFactory::GetForBrowserState( TabRestoreServiceDelegateImplIOSFactory::GetForBrowserState(
ios::ChromeBrowserState* browser_state) { ChromeBrowserState* browser_state) {
return static_cast<TabRestoreServiceDelegateImplIOS*>( return static_cast<TabRestoreServiceDelegateImplIOS*>(
GetInstance()->GetServiceForBrowserState(browser_state, true)); GetInstance()->GetServiceForBrowserState(browser_state, true));
} }
...@@ -43,5 +43,5 @@ std::unique_ptr<KeyedService> ...@@ -43,5 +43,5 @@ std::unique_ptr<KeyedService>
TabRestoreServiceDelegateImplIOSFactory::BuildServiceInstanceFor( TabRestoreServiceDelegateImplIOSFactory::BuildServiceInstanceFor(
web::BrowserState* context) const { web::BrowserState* context) const {
return std::make_unique<TabRestoreServiceDelegateImplIOS>( return std::make_unique<TabRestoreServiceDelegateImplIOS>(
ios::ChromeBrowserState::FromBrowserState(context)); ChromeBrowserState::FromBrowserState(context));
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment