Commit 9c58d619 authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Add task scheduler and cpu_sampler information to slow-reports.

This CL is turning on the CPU sampler category.
  see: https://chromium-review.googlesource.com/c/chromium/src/+/1191745/

It's also turning on the task scheduler info. Which is adding the
task_priority to the trace and will ease finding priority inversion.

  Title          TaskTracker::RunTask
  Category       task_scheduler
  Args
    task_info    {execution_mode: "parallel", task_priority: "USER_BLOCKING"}


R=etiennep@chromium.org, oysteine@chromium.org

Bug: 867931
Change-Id: I8f6e4772816cc446a25c04ce0cda4b9d45c44232
Reviewed-on: https://chromium-review.googlesource.com/1199567
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588179}
parent e7bb5dba
...@@ -30,9 +30,10 @@ const WhitelistEntry kEventArgsWhitelist[] = { ...@@ -30,9 +30,10 @@ const WhitelistEntry kEventArgsWhitelist[] = {
{"__metadata", "typeNames", nullptr}, {"__metadata", "typeNames", nullptr},
{"ipc", "GpuChannelHost::Send", nullptr}, {"ipc", "GpuChannelHost::Send", nullptr},
{"ipc", "SyncChannel::Send", nullptr}, {"ipc", "SyncChannel::Send", nullptr},
{"toplevel", "*", nullptr},
{"latencyInfo", "*", kInputLatencyAllowedArgs}, {"latencyInfo", "*", kInputLatencyAllowedArgs},
{"omnibox", "HistoryQuickProvider::Start", nullptr}, {"task_scheduler", "*", nullptr},
{"toplevel", "*", nullptr},
{TRACE_DISABLED_BY_DEFAULT("cpu_profiler"), "StackCpuSampling", nullptr},
// Redefined the string since MemoryDumpManager::kTraceCategory causes // Redefined the string since MemoryDumpManager::kTraceCategory causes
// static initialization of this struct. // static initialization of this struct.
{TRACE_DISABLED_BY_DEFAULT("memory-infra"), "*", kMemoryDumpAllowedArgs}, {TRACE_DISABLED_BY_DEFAULT("memory-infra"), "*", kMemoryDumpAllowedArgs},
......
...@@ -669,7 +669,8 @@ TraceConfig BackgroundTracingManagerImpl::GetConfigForCategoryPreset( ...@@ -669,7 +669,8 @@ TraceConfig BackgroundTracingManagerImpl::GetConfigForCategoryPreset(
case BackgroundTracingConfigImpl::CategoryPreset::BENCHMARK_NAVIGATION: { case BackgroundTracingConfigImpl::CategoryPreset::BENCHMARK_NAVIGATION: {
auto config = TraceConfig( auto config = TraceConfig(
"benchmark,toplevel,ipc,base,browser,navigation,omnibox," "benchmark,toplevel,ipc,base,browser,navigation,omnibox,"
"safe_browsing,disabled-by-default-system_stats", "safe_browsing,task_scheduler,task_scheduler_diagnostics"
"disabled-by-default-system_stats,disabled-by-default-cpu_profiler",
record_mode); record_mode);
// Filter only browser process events. // Filter only browser process events.
base::trace_event::TraceConfig::ProcessFilterConfig process_config( base::trace_event::TraceConfig::ProcessFilterConfig process_config(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment