Cleanup chrome/browser/metrics url constants

BUG=476211

Review URL: https://codereview.chromium.org/1060743003

Cr-Commit-Position: refs/heads/master@{#325552}

chrome/browser/metrics/variations/url_constants.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/variations/url_constants.h"
+
+namespace chrome_variations {
+
+// Default server of Variations seed info.
+const char kDefaultServerUrl[] =
+    "https://clients4.google.com/chrome-variations/seed";
+
+}  // namespace chrome_variations

chrome/browser/metrics/variations/url_constants.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_VARIATIONS_URL_CONSTANTS_H_
+#define CHROME_BROWSER_METRICS_VARIATIONS_URL_CONSTANTS_H_
+
+namespace chrome_variations {
+
+extern const char kDefaultServerUrl[];
+
+}  // namespace chrome_variations
+
+#endif  // CHROME_BROWSER_METRICS_VARIATIONS_URL_CONSTANTS_H_

chrome/browser/metrics/variations/variations_service.cc

@@ -18,6 +18,7 @@
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/metrics/variations/generated_resources_map.h"
+#include "chrome/browser/metrics/variations/url_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/metrics_state_manager.h"
@@ -52,9 +53,6 @@ namespace chrome_variations {
 
 namespace {
 
-// Default server of Variations seed info.
-const char kDefaultVariationsServerURL[] =
-    "https://clients4.google.com/chrome-variations/seed";
 const int kMaxRetrySeedFetch = 5;
 
 // TODO(mad): To be removed when we stop updating the NetworkTimeTracker.
@@ -383,7 +381,7 @@ GURL VariationsService::GetVariationsServerURL(
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kVariationsServerURL));
   if (server_url_string.empty())
-    server_url_string = kDefaultVariationsServerURL;
+    server_url_string = kDefaultServerUrl;
   GURL server_url = GURL(server_url_string);
 
   const std::string restrict_param = !restrict_mode_override.empty() ?
@@ -403,7 +401,7 @@ GURL VariationsService::GetVariationsServerURL(
 
 // static
 std::string VariationsService::GetDefaultVariationsServerURLForTesting() {
-  return kDefaultVariationsServerURL;
+  return kDefaultServerUrl;
 }
 
 // static

chrome/chrome_browser.gypi

@@ -1771,6 +1771,8 @@
       'browser/metrics/time_ticks_experiment_win.h',
       'browser/metrics/variations/generated_resources_map.h',
       'browser/metrics/variations/generated_resources_map_lookup.cc',
+      'browser/metrics/variations/url_constants.cc',
+      'browser/metrics/variations/url_constants.h',
       'browser/metrics/variations/variations_registry_syncer_win.cc',
       'browser/metrics/variations/variations_registry_syncer_win.h',
       'browser/metrics/variations/variations_request_scheduler.cc',