Commit 9dbabf15 authored by Fergal Daly's avatar Fergal Daly Committed by Commit Bot

Add more debugging for https://crbug.com/1006814.

Record whether we are currently in the middle of dispatching handlers
for process-death as this is a stronger contender for how this is
occurring.

Bug: 1006814
Change-Id: I0d269c250a870c25088e92c4b207e7fa647f0bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106987Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751604}
parent a3942a8f
...@@ -2221,11 +2221,15 @@ RenderFrameHostManager::CreateSpeculativeRenderFrame(SiteInstance* instance) { ...@@ -2221,11 +2221,15 @@ RenderFrameHostManager::CreateSpeculativeRenderFrame(SiteInstance* instance) {
int main_rfh_routing_id = int main_rfh_routing_id =
render_view_host->GetMainFrameRoutingIdForCrbug1006814(); render_view_host->GetMainFrameRoutingIdForCrbug1006814();
std::string message = base::StringPrintf( std::string message = base::StringPrintf(
"created=%d,process=%d,proxy=%d,widget=%d,main_rfh=%d,new_rfh=%d", "created=%d,process=%d,proxy=%d,widget=%d,main_rfh=%d,new_rfh=%d,"
"in_pdo=%d",
new_render_frame_host->IsRenderFrameCreated(), new_render_frame_host->IsRenderFrameCreated(),
new_render_frame_host->GetProcess()->IsInitializedAndNotDead(), new_render_frame_host->GetProcess()->IsInitializedAndNotDead(),
!!GetRenderFrameProxyHost(instance), widget_renderer_initialized, !!GetRenderFrameProxyHost(instance), widget_renderer_initialized,
main_rfh_routing_id, new_render_frame_host->routing_id()); main_rfh_routing_id, new_render_frame_host->routing_id(),
static_cast<RenderProcessHostImpl*>(
render_view_host->GetWidget()->GetProcess())
->GetWithinProcessDiedObserverForCrbug1006814());
// This string is whitelisted for collection from Android Webview. It must // This string is whitelisted for collection from Android Webview. It must
// only contain booleans to avoid leaking any PII. // only contain booleans to avoid leaking any PII.
base::debug::SetCrashKeyString(crash_key, message); base::debug::SetCrashKeyString(crash_key, message);
......
...@@ -297,6 +297,11 @@ class CONTENT_EXPORT RenderProcessHostImpl ...@@ -297,6 +297,11 @@ class CONTENT_EXPORT RenderProcessHostImpl
child_process_activity_time_ = base::TimeTicks::Now(); child_process_activity_time_ = base::TimeTicks::Now();
} }
// TODO(https://crbug.com/1006814): Delete this.
bool GetWithinProcessDiedObserverForCrbug1006814() {
return within_process_died_observer_;
}
// Used to extend the lifetime of the sessions until the render view // Used to extend the lifetime of the sessions until the render view
// in the renderer is fully closed. This is static because its also called // in the renderer is fully closed. This is static because its also called
// with mock hosts as input in test cases. The RenderWidget routing associated // with mock hosts as input in test cases. The RenderWidget routing associated
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment