Skip to content

GitLab

T
tangled
Commit 9e41db58 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot
Browse files
Options

Android: Re-enable 14 useful lint warnings (reland) 

Many of these lint warnings were turned off because it was difficult to
fix all of them when they were introduced (usually via a lint update)
and fix incoming new errors at the same time.

Adding existing issues to the baseline and enabling for new code.

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2369576

Fixed:
  - Regenerated baseline post-revert of a previous refactor that changed
    filepaths of errors that were in lint-baseline.xml.

Bug: 1116130,807734,671170,831774,635567
Bug: 1069186,804427
Fixed: 807734,635567,804427

TBR=wnwen@chromium.org,twellington@chromium.org,agrieve@chromium.org

Change-Id: I52fd71ed6678d35d5d31567be3038c53e544fa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372928Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801155}
parent 0fb40ee0
Show whitespace changes
Inline Side-by-side
Showing with 1127 additions and 50 deletions
chrome/android/expectations/lint-baseline.xml
View file @ 9e41db58
......@@ -52,7 +52,7 @@
errorLine2=" ~~">
<location
file="../../chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/CriticalPersistedTabData.java"
line="229"
line="281"
column="24"/>
</issue>
......@@ -254,6 +254,380 @@
column="45"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="15"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="22"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="28"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="38"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="44"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="50"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="55"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/bookmark_action_bar_menu.xml"
line="59"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/menu/download_manager_menu.xml"
line="16"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/menu/download_manager_menu.xml"
line="23"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/menu/download_manager_menu.xml"
line="29"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/menu/download_manager_menu.xml"
line="39"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/menu/download_manager_menu.xml"
line="45"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="16"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="22"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="28"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="38"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="43"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="47"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/history_manager_menu.xml"
line="51"
column="13"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;always&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/languages_action_bar_menu.xml"
line="12"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:actionViewClass` when not using the appcompat library"
errorLine1=" app:actionViewClass=&quot;androidx.appcompat.widget.SearchView&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/languages_action_bar_menu.xml"
line="13"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;always&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/password_check/android/java/res/menu/password_check_editor_action_bar_menu.xml"
line="12"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;always&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml"
line="12"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/password_entry_viewer_action_bar_menu.xml"
line="15"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/password_entry_viewer_action_bar_menu.xml"
line="23"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/prefeditor_editor_menu.xml"
line="13"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/prefeditor_editor_menu.xml"
line="20"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;always&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml"
line="13"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:actionViewClass` when not using the appcompat library"
errorLine1=" app:actionViewClass=&quot;androidx.appcompat.widget.SearchView&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml"
line="14"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;ifRoom&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml"
line="20"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;never&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml"
line="26"
column="9"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:showAsAction` when not using the appcompat library"
errorLine1=" app:showAsAction=&quot;always&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/res/menu/website_preferences_menu.xml"
line="10"
column="11"/>
</issue>
<issue
id="AppCompatResource"
message="Should use `android:actionViewClass` when not using the appcompat library"
errorLine1=" app:actionViewClass=&quot;androidx.appcompat.widget.SearchView&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/res/menu/website_preferences_menu.xml"
line="11"
column="11"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -756,7 +1130,7 @@
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="359"
line="356"
column="84"/>
</issue>
......@@ -767,7 +1141,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="752"
line="723"
column="23"/>
</issue>
......@@ -789,7 +1163,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java"
line="825"
line="779"
column="67"/>
</issue>
......@@ -1002,17 +1376,6 @@
column="40"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" save();"
errorLine2=" ~~~~">
<location
file="../../chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/MockPersistedTabData.java"
line="65"
column="9"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -1251,7 +1614,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java"
line="106"
line="111"
column="48"/>
</issue>
......@@ -1262,7 +1625,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java"
line="120"
line="125"
column="40"/>
</issue>
......@@ -1273,7 +1636,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java"
line="127"
line="132"
column="48"/>
</issue>
......@@ -1508,6 +1871,17 @@
column="1"/>
</issue>
<issue
id="UseSparseArrays"
message="Use `new SparseBooleanArray(...)` instead for better performance"
errorLine1=" mGroupsCollapsedState = new SparseArray&lt;>();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/DropdownItemViewInfoListManager.java"
line="34"
column="33"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
......@@ -1552,4 +1926,730 @@
column="10"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `AccessibilityTabModelListItem` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent e) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/accessibility_tab_switcher/AccessibilityTabModelListItem.java"
line="453"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``SurfaceView`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mSurfaceView.setOnTouchListener(ArImmersiveOverlay.this);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/vr/ArImmersiveOverlay.java"
line="176"
column="13"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`ArImmersiveOverlay#onTouch` should call `View#performClick` when a click is detected"
errorLine1=" public boolean onTouch(View v, MotionEvent ev) {"
errorLine2=" ~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/vr/ArImmersiveOverlay.java"
line="222"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" row.setDragHandleOnTouchListener((v, event) -> {"
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java"
line="213"
column="46"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageView`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mDragHandle.setOnTouchListener(l);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java"
line="270"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `BottomSheet` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent e) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/browser_ui/android/bottomsheet/internal/java/src/org/chromium/components/browser_ui/bottomsheet/BottomSheet.java"
line="251"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `BrowsingModeBottomToolbarLinearLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarLinearLayout.java"
line="48"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``TextView`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" textView.setOnTouchListener(new ChunkedTextTouchListener(spannable));"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/library/piet/ChunkedTextElementAdapter.java"
line="159"
column="17"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`ChunkedTextTouchListener#onTouch` should call `View#performClick` when a click is detected"
errorLine1=" public boolean onTouch(View widget, MotionEvent event) {"
errorLine2=" ~~~~~~~">
<location
file="../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/library/piet/ChunkedTextElementAdapter.java"
line="383"
column="24"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``TextView`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" textView.setOnTouchListener((View v, MotionEvent event) -> {"
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataCheckBoxPreference.java"
line="54"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" textView.setOnTouchListener((View v, MotionEvent event) -> {"
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/browsing_data/ClearBrowsingDataCheckBoxPreference.java"
line="54"
column="37"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `CompositorViewHolder` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent e) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java"
line="635"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ContentView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java"
line="333"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `InterceptTouchLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java"
line="125"
column="24"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" menuBtn.setOnTouchListener(menuPopupButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/tablet/emptybackground/EmptyBackgroundViewTablet.java"
line="98"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `FirstRunViewPager` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunViewPager.java"
line="21"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``EditText`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" editText.setOnTouchListener((View v, MotionEvent event) -> {"
errorLine2=" ^">
<location
file="../../android_webview/nonembedded/java/src/org/chromium/android_webview/devui/FlagsFragment.java"
line="165"
column="13"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" editText.setOnTouchListener((View v, MotionEvent event) -> {"
errorLine2=" ^">
<location
file="../../android_webview/nonembedded/java/src/org/chromium/android_webview/devui/FlagsFragment.java"
line="165"
column="41"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``EditText`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" editText.setOnTouchListener(null);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/nonembedded/java/src/org/chromium/android_webview/devui/FlagsFragment.java"
line="180"
column="13"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `FullScreenView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(final MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/FullScreenView.java"
line="91"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `InfoBarMessageView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/infobars/android/java/src/org/chromium/components/infobars/InfoBarMessageView.java"
line="32"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageView`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" holder.mStartIcon.setOnTouchListener((v, event) -> {"
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/language/settings/LanguageListBaseAdapter.java"
line="173"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" holder.mStartIcon.setOnTouchListener((v, event) -> {"
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/language/settings/LanguageListBaseAdapter.java"
line="173"
column="46"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `LocationBarTablet` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java"
line="112"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mMenuImageButton.setOnTouchListener(mAppMenuButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButton.java"
line="78"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" View.OnTouchListener onTouchListener = (View v, MotionEvent ev) -> {"
errorLine2=" ^">
<location
file="../../components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogView.java"
line="206"
column="48"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``Button`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" positiveButton.setOnTouchListener(onTouchListener);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogView.java"
line="236"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``Button`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" negativeButton.setOnTouchListener(onTouchListener);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogView.java"
line="238"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `NoSwipeViewPager` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/sheet_component/NoSwipeViewPager.java"
line="24"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` should call `View#performClick` when a click is detected"
errorLine1=" public boolean onTouch(View v, MotionEvent event) {"
errorLine2=" ~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerVideoPlayer.java"
line="231"
column="28"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `PlayerFrameView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameView.java"
line="108"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ScrimView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent e) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/scrim/ScrimView.java"
line="79"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ScrollingBottomViewResourceFrameLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/ScrollingBottomViewResourceFrameLayout.java"
line="63"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" mEmptyViewWrapper.setOnTouchListener((v, event) -> true);"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/selectable_list/SelectableListLayout.java"
line="243"
column="46"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mMenuButton.getImageButton().setOnTouchListener(appMenuButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/StartSurfaceToolbarView.java"
line="96"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" mMenuButton.getImageButton().setOnTouchListener(appMenuButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TabSwitcherModeTTPhone.java"
line="190"
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `TextEditorHandleView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../clank/browser/image_editor/internal/java/src/org/chromium/chrome/browser/image_editor/text/TextEditorHandleView.java"
line="142"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ToolbarControlContainer` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainer.java"
line="249"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``ImageButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" menuButton.setOnTouchListener(appMenuButtonHelper);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java"
line="134"
column="17"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `ToolbarPhone` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent ev) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java"
line="518"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `TouchRestrictingFrameLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/browser_ui/android/bottomsheet/internal/java/src/org/chromium/components/browser_ui/bottomsheet/TouchRestrictingFrameLayout.java"
line="46"
column="20"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` should call `View#performClick` when a click is detected"
errorLine1=" public boolean onTouch(View view, MotionEvent event) {"
errorLine2=" ~~~~~~~">
<location
file="../../weblayer/browser/java/org/chromium/weblayer_private/WebContentsGestureStateTracker.java"
line="48"
column="28"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/features/autofill_assistant/java/res/layout/autofill_assistant_bottom_sheet_content.xml"
line="8"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/bottom_toolbar_menu_button.xml"
line="12"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot; >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/bottom_toolbar_tab_switcher.xml"
line="15"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/contacts_list_item_view.xml"
line="48"
column="17"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/contacts_list_item_view.xml"
line="72"
column="17"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/contacts_list_item_view.xml"
line="96"
column="17"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_card_footer.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_generic_item.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_image_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_image_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_video_item.xml"
line="12"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_prefetch_article.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_video_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/languages_preference.xml"
line="32"
column="9"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../clank/browser/image_editor/internal/java/res/layout/line_tool_color_item.xml"
line="16"
column="9"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/photo_picker_dialog.xml"
line="36"
column="9"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot; >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/search_activity.xml"
line="28"
column="13"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/share_sheet_item.xml"
line="10"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/start_top_toolbar.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot; >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/tab_switcher_toolbar.xml"
line="12"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/video_player.xml"
line="37"
column="9"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/video_player.xml"
line="99"
column="17"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/video_player.xml"
line="124"
column="17"/>
</issue>
</issues>
chrome/android/expectations/lint-suppressions.xml
View file @ 9e41db58
......@@ -19,9 +19,6 @@ Still reading?
<ignore regexp="android_webview/tools/system_webview_shell/apk/res/xml/network_security_config.xml"/>
<ignore regexp="test"/>
</issue>
<issue id="AllowBackup" severity="ignore"/>
<!-- TODO(crbug.com/804427): Remove this suppression or add rationale. -->
<issue id="AppCompatResource" severity="ignore"/>
<issue id="Autofill">
<!-- Filed https://crbug.com/1073966 to fix -->
<ignore regexp="chrome/android/features/tab_ui/java/res/layout/bottom_tab_grid_toolbar.xml"/>
......@@ -32,11 +29,9 @@ Still reading?
<ignore regexp="chrome/android/javatests"/>
<ignore regexp="Test.java"/>
</issue>
<issue id="BadHostnameVerifier"/>
<issue id="ButtonOrder">
<ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/>
</issue>
<issue id="ClickableViewAccessibility" severity="ignore"/>
<issue id="ContentDescription">
<!--TODO(crbug.com/1044658): This suppression was added blindly, and needs investigated.-->
<ignore regexp="chrome/android/java/res/layout/contacts_list_item_view.xml"/>
......@@ -57,19 +52,11 @@ Still reading?
<!-- TODO(crbug.com/1082222): Fix -->
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/header/HeaderProcessor.java"/>
</issue>
<!--TODO(crbug.com/1069186): See if this new check is useful. -->
<issue id="DuplicateDefinition" severity="ignore"/>
<issue id="DuplicateIds" severity="Fatal">
<!--TODO(crbug.com/1044658): This suppression was added blindly, and needs investigated.-->
<ignore regexp="chrome/android/java/res/menu/main_menu.xml"/>
<ignore regexp="chrome/android/java/res/menu/main_menu_regroup.xml"/>
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="Deprecated">
<ignore regexp="/test/"/>
<ignore regexp="AndroidManifest.xml"/>
<ignore regexp="android:singleLine"/>
</issue>
<issue id="DrawAllocation">
<ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
<ignore regexp="content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java"/>
......@@ -82,14 +69,9 @@ Still reading?
</issue>
<issue id="ExportedContentProvider" severity="ignore"/>
<issue id="ExportedService" severity="ignore"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="GoogleAppIndexingUrlError" severity="ignore"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="GoogleAppIndexingWarning" severity="ignore"/>
<issue id="HandlerLeak">
<ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java"/>
</issue>
<issue id="HardcodedDebugMode" severity="ignore"/>
<issue id="IconColors">
<ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-.*/notification_icon.png"/>
</issue>
......@@ -167,8 +149,6 @@ Still reading?
<issue id="InlinedApi" severity="ignore"/>
<issue id="InvalidVectorPath" severity="ignore"/>
<issue id="JobSchedulerService" severity="ignore"/>
<!-- TODO(crbug.com/804453): Remove this after fixing. -->
<issue id="KeyboardInaccessibleWidget" severity="ignore"/>
<issue id="LabelFor">
<ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
</issue>
......@@ -188,8 +168,6 @@ Still reading?
<ignore regexp="chrome/android/java/res/layout-sw360dp/preference_spinner_single_line.xml"/>
</issue>
<issue id="MissingPermission" severity="ignore"/>
<!-- TODO(yolandyan) remove this once all tests are converted to junit4 -->
<issue id="MissingPrefix" severity="ignore"/>
<issue id="MissingQuantity" severity="ignore"/>
<issue id="MissingRegistered" severity="ignore"/>
<issue id="MissingSuperCall">
......@@ -199,7 +177,6 @@ Still reading?
<issue id="MissingTranslation">
<ignore regexp="restriction_values.xml.*"/>
</issue>
<issue id="MissingVersion" severity="ignore"/>
<issue id="NewApi">
<!-- Do not add new suppressions without rationale. -->
<!-- 2: We support these via desugar. -->
......@@ -223,7 +200,8 @@ Still reading?
<issue id="ObsoleteSdkInt" severity="ignore"/>
<issue id="OldTargetApi" severity="ignore"/>
<issue id="OnClick">
<!-- False positive, see: http://issuetracker.google.com/148523770 for similar issue. -->
<!-- False positive, see: http://issuetracker.google.com/148523770 for
similar issue. -->
<ignore regexp="tools/android/audio_focus_grabber/java/res/layout/audio_focus_grabber_activity.xml"/>
</issue>
<issue id="Overdraw" severity="ignore"/>
......@@ -244,12 +222,11 @@ Still reading?
<issue id="ResourceType">
<ignore regexp="/javatests/"/>
</issue>
<!-- TODO(crbug.com/831774): Play Services starts complaining about RestrictedApi. Needs investigation -->
<issue id="RestrictedApi" severity="ignore"/>
<issue id="RtlCompat" severity="ignore"/>
<issue id="RtlEnabled" severity="ignore"/>
<issue id="RtlHardcoded">
<!--TODO(crbug.com/1044658): This suppression was added blindly, and needs investigated.-->
<!--TODO(crbug.com/1044658): This suppression was added blindly, and needs
investigated.-->
<ignore regexp="chrome/android/java/res/layout/sheet_tab_toolbar.xml"/>
</issue>
<issue id="RtlSymmetry" severity="ignore"/>
......@@ -272,14 +249,16 @@ Still reading?
<!-- This string has a % in it. -->
<ignore regexp="data_reduction_promo_infobar_title"/>
</issue>
<!-- Many .xtb files have a % that is not part of a formatted string. https://crbug.com/941164 -->
<!-- Many .xtb files have a % that is not part of a formatted string.
https://crbug.com/941164 -->
<issue id="StringFormatInvalid" severity="ignore"/>
<issue id="StringFormatMatches" severity="ignore"/>
<!-- Code is usually committed in English for all languages and later
translated. This avoids blocking translation updates. -->
<issue id="Typos" severity="ignore"/>
<issue id="TypographyDashes">
<ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml"/>
</issue>
<!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
<issue id="Typos" severity="ignore"/>
<issue id="UnusedIds" severity="ignore"/>
<issue id="UnusedQuantity" severity="ignore"/>
<issue id="UnusedResources">
......@@ -392,8 +371,6 @@ Still reading?
<!-- Cannot add image to textview as the image is supplied through @style/TabBarShadow. -->
<ignore regexp="chrome/browser/share/android/java/res/layout/qrcode_camera_error_layout.xml"/>
</issue>
<!-- TODO(crbug.com/807734): Investigate and possible remove this -->
<issue id="UseSparseArrays" severity="ignore"/>
<issue id="UselessParent">
<ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
<ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment