Update non-fast scrollable region tests to force noncomposited scrolling

These tests were relying on scrollers not being composited and did not pass with --enable-prefer-compositing-to-lcd-text. This patch updates the tests to explicitly disable composited scrolling. Bug: 1085035 Change-Id: I5f2be2c7c57ce535801c9498a87ba42635906faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209993 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771102}

Update non-fast scrollable region tests to force noncomposited scrolling
These tests were relying on scrollers not being composited and did not pass with --enable-prefer-compositing-to-lcd-text. This patch updates the tests to explicitly disable composited scrolling. Bug: 1085035 Change-Id: I5f2be2c7c57ce535801c9498a87ba42635906faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209993 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771102}
9edc3c40 · Philip Rogers · Commit Bot · 12a95f24 · 9edc3c40 · 9edc3c40
Commit 9edc3c40 authored May 21, 2020 by Philip Rogers Committed by Commit Bot May 21, 2020
6 changed files
--- a/third_party/blink/web_tests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html
@@ -12,6 +12,13 @@
  }
 </style>

+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
+
 <iframe id='iframe' src='resources/iframe-containing-non-fast-scrollables.html'></iframe>

 <script src="resources/non-fast-scrollable-region-testing.js"></script>

--- a/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-nested.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-nested.html
@@ -12,6 +12,13 @@
  }
 </style>

+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
+
 <iframe id='iframe' src='resources/iframe-containing-non-fast-scrollables.html'></iframe>

 <div id="console"></div>

--- a/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
@@ -14,6 +14,13 @@
  }
 </style>

+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
+
 <iframe src="data:text/html;charset=utf-8,<html><body style='width:1000px;height:1000px;'>Should be covered by a green overlay.</body></html>"></iframe>
 <div id="console"></div>
 <div class="spacer"></div>

--- a/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
@@ -15,6 +15,13 @@
  }
 </style>

+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
+
 <iframe srcdoc="
  <!DOCTYPE html>
  <style>

--- a/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-transform-changed.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-transform-changed.html
@@ -23,7 +23,12 @@
    height: 2000px;
  }
 </style>
-
+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
 <div id='nonFastRegion'><div>This should be covered by a green overlay.</div></div>

 <p>A single square should be visible covered by a green overlay.</p>

--- a/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-visibility-change.html
+++ b/third_party/blink/web_tests/scrollingcoordinator/non-fast-scrollable-visibility-change.html
@@ -26,7 +26,12 @@
    border: none;
  }
 </style>
-
+<script>
+  // Prefer non-composited scrolling because this is a test of non-composited
+  // scrollers.
+  if (window.internals)
+    internals.settings.setPreferCompositingToLCDTextEnabled(false);
+</script>
 <section id='div' style="display:none;">
  <div class="to-show container">
  </div>