Commit a0bf7a19 authored by Eric Stevenson's avatar Eric Stevenson Committed by Commit Bot

Android: Enable feed and multidex.

chrome_modern_public_apk and chrome_public_apk hit the single dex
method limit when feed is enabled. This CL re-enables feed while also
turning on multidex for the required APKs.

Binary-Size: Feed was disabled to fix the multidex method limit issue.
Bug: 901488
Change-Id: Ifba41178fad6c206ec1f458d420187ef1c2eb6f3
Reviewed-on: https://chromium-review.googlesource.com/c/1327403
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: default avatarSky Malice <skym@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606670}
parent 600d8e9f
...@@ -1464,6 +1464,9 @@ template("chrome_public_apk_or_module_tmpl") { ...@@ -1464,6 +1464,9 @@ template("chrome_public_apk_or_module_tmpl") {
load_library_from_apk = _is_modern && chromium_linker_supported load_library_from_apk = _is_modern && chromium_linker_supported
version_name = chrome_version_name version_name = chrome_version_name
if (experimental_r8_path == "") {
enable_multidex = true
}
} }
} }
......
...@@ -53,6 +53,7 @@ CHROME_CHANGES = BuildFileMatchRegex( ...@@ -53,6 +53,7 @@ CHROME_CHANGES = BuildFileMatchRegex(
r'AndroidManifest\.xml', r'AndroidManifest\.xml',
r'resources\.arsc', r'resources\.arsc',
r'classes\.dex', r'classes\.dex',
r'classes2\.dex',
r'res/.*\.xml', # Resource id isn't same r'res/.*\.xml', # Resource id isn't same
r'assets/unwind_cfi_32', # Generated from apk's shared library r'assets/unwind_cfi_32', # Generated from apk's shared library
# All pak files except chrome_100_percent.pak are different # All pak files except chrome_100_percent.pak are different
......
...@@ -3,7 +3,5 @@ ...@@ -3,7 +3,5 @@
# found in the LICENSE file. # found in the LICENSE file.
declare_args() { declare_args() {
# TODO(agrieve): Set this back to "is_android" once enable_feed_in_chrome = is_android
# https://crbug.com/901488 is fixed
enable_feed_in_chrome = false
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment